Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an interface for Preconditions. #4

Open
Tylertron1998 opened this issue Jan 4, 2021 · 0 comments
Open

Create an interface for Preconditions. #4

Tylertron1998 opened this issue Jan 4, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tylertron1998
Copy link
Owner

Tylertron1998 commented Jan 4, 2021 •
edited
Loading

As the title suggests, we need a type for preconditions, for checking if a command should run.

Something to consider here: how about passing data? Should the precondition have access to the command arguments? I think personally not. If there is an issue with the arguments that should be handled by the command.
@Tylertron1998 Tylertron1998 added enhancement New feature or request good first issue Good for newcomers labels Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tylertron1998