Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite 5.4.1 + appPlayground = next is not a function #814

Open
rubenfiszel opened this issue Jan 6, 2025 · 3 comments
Open

vite 5.4.1 + appPlayground = next is not a function #814

rubenfiszel opened this issue Jan 6, 2025 · 3 comments

Comments

@rubenfiszel
Copy link

I'm not sure this is a monaco language-client issue but we're on vite 5.4 and the appPlayground had an issue because it relies on importing:

http://localhost:3000/node_modules/@codingame/monaco-vscode-extensions-service-override/assets/webWorkerExtensionHostIframe.html?&vscodeWebWorkerExtHostId=6fdd6fd7-b142-4a8a-8076-3e736882eae4

but at the very least vite 5.4.x has an issue with it because it is then served by:
https://github.com/vitejs/vite/blob/da0caf5f9f25ed1803bfed0193b1d8d7b6a71631/packages/vite/src/node/server/middlewares/static.ts#L121

The fix for vite is here: vitejs/vite#19141 but I wonder if it's not caused by something deeper in the ways assets are bundled. In any case, I thought I would report it here and in vite

@kaisalmen
Copy link
Collaborator

Hi @rubenfiszel thank you for reporting. Does the problem still exist with vite 6?
Any idea if or how we can reproduce this with the online demo? https://typefox.github.io/monaco-languageclient/ghp_appPlayground.html

@kaisalmen
Copy link
Collaborator

Or is this only a dev server issue and does not occur with the production build?

@rubenfiszel
Copy link
Author

@kaisalmen I can't reproduce on my local version of the appPlayground so it might be solved in vite 6, will try to see if it happens in build as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants