Skip to content

Commit ffcede3

Browse files
tf-setiSourcegraphglean-code-writerpromiseNwafor
authored
chore(PLT-3524): remove SonarCloud setup (#746)
* chore(PLT-3524): remove SonarCloud setup * Remove remaining SonarCloud reference from workflow comment Generated by Glean Code Writer * fix: update test --------- Co-authored-by: Sourcegraph <batch-changes@sourcegraph.com> Co-authored-by: glean-code-writer <code_writer@glean.com> Co-authored-by: promiseNwafor <promise.nwafor@typeform.com>
1 parent 05ed193 commit ffcede3

3 files changed

Lines changed: 2 additions & 23 deletions

File tree

.github/workflows/pull-request.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
matrix:
1212
node_version:
13-
- 24 # end of life 2028-04-30 # used in SonarCloud scan
13+
- 24 # end of life 2028-04-30
1414
name: build-lint-test - node ${{ matrix.node_version }}
1515
steps:
1616
- name: Check out Git repository
@@ -42,15 +42,6 @@ jobs:
4242
- name: Verify coverage file ready
4343
run: find . | grep coverage
4444

45-
- name: SonarCloud Scan
46-
uses: SonarSource/sonarqube-scan-action@v7
47-
with:
48-
args: >
49-
"-Dsonar.projectVersion=${{ github.run_id }}"
50-
env:
51-
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
52-
SONAR_TOKEN: ${{ secrets.SONAR_CLOUD_TOKEN }}
53-
LC_ALL: 'C.UTF-8'
5445

5546
functional:
5647
runs-on: ubuntu-latest

packages/embed/e2e/spec/functional/widget-newui.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function testMobile(path: string, title: string) {
5555
it('should reset the form when closing it', () => {
5656
cy.get('iframe').then(($iframe) => {
5757
const $body = $iframe.contents().find('body')
58-
cy.wrap($body).find('[data-qa="ok-button"]').click()
58+
cy.wrap($body).find('[data-qa="ok-button"]').click({ force: true })
5959
cy.get('.tf-v1-widget-close').click()
6060
})
6161
cy.wait(1000)

sonar-project.properties

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)