Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors when run #561

Closed
bf2spy opened this issue Nov 12, 2023 · 14 comments
Closed

errors when run #561

bf2spy opened this issue Nov 12, 2023 · 14 comments
Assignees
Labels

Comments

@bf2spy
Copy link

bf2spy commented Nov 12, 2023

This project is great, but when I ran it I got some errors
When I access it with ip address 127.0.0.1:3005,no errors
But when I access it with ip address 192.168.0.20:3005 or my domain name for example www.xxxx.com:3005,it shows errors in the terminal:
ws.go:85 Failed to set websocket upgrade: webcocket: request origin not allowed by upgrader.checkorigin

Even so, I can register and login normally, and add repeaters normally,test with Google Chrome。

Enroll New peer -INOP failed unless modify from “peers#” to “peers/new"

@USA-RedDragon
Copy link
Owner

USA-RedDragon commented Nov 18, 2023

Thanks for trying out DMRHub!

But when I access it with ip address 192.168.0.20:3005 or my domain name for example www.xxxx.com:3005,it shows errors in the terminal

It sounds like you're hitting CORS issues. Make sure to set the CORS_HOST environment variable for your environment. The env vars are documented here: https://github.com/USA-RedDragon/DMRHub/wiki/Environment-Variables

Basically, you'll want to add any (fully-qualified URLs) of hosts that you'd like to access DMRHub at, i.e. CORS_HOST="http://127.0.0.1:3005,http://192.168.0.20:3005,http://www.xxxx.com:3005,https://www.xxxx.com"

Enroll New peer -INOP failed unless modify from “peers#” to “peers/new"

As far as peers and OpenBridge, that's still a WIP. The -INOP means literally "inoperable". I intend to have a feature flag for this soon so it won't show up on releases until it's ready. #81 is the issue tracking OpenBridge support.

@USA-RedDragon
Copy link
Owner

USA-RedDragon commented Nov 18, 2023

v1.0.44 is releasing now that removes the evidence of OpenBridge support (the items that were previously broken and marked INOP) until it's ready.

@bf2spy
Copy link
Author

bf2spy commented Nov 18, 2023

Thank you very much for your efforts
Now that CORS_HOST has been added, it has been accessed normally without errors.

After comparison, I found that your project is better than freedmr and hblink!
Looking forward to its more and more perfect, I use the firmware of the mmdvm to do the hotspot board relay test, there has been a puzzling problem, the configuration environment is as follows:
Client 1: mmdvmhost----dmrgateway-----dmrhub register and add a trunk
Static call groups 123456 and 123457

Client 2: mmdvmhost----dmrgateway-----dmrhub register and add a trunk
Static call groups 123458 and 123459

When client1 makes a call in talkgroup 123456, client2 can copy the call in talkgroup 123458.

The function I understand is that calls can only be received in the same talkgroup
For example, when client1 makes a call in call group 123456, client2 can receive the call only after adding dynamic talkgroup 123456. After dynamic talkgroup 123456 is deleted, client1 cannot receive the call

The current situation is that after a client makes a call to any call group, other clients can receive a call even if they are not in the same talkgroup

My walkie-talkie uses opengd77 firmware and has not yet been tested with other walkie-talkie.
I will test further and give feedback later

@bf2spy
Copy link
Author

bf2spy commented Nov 18, 2023

Another issue is that mmdvmhost's repeater password support for dmrhub is not very good
When I filled in the Password of mmdvmhost prompted by the repeater in the password of pi-star mmdvmhost, mmdvmhost stopped running. I tried to add and delete the repeater once to get a password that could be supported, but found that the special symbol would cause MMDVmhost to stop working. For example, a password that contains @%&* characters.
I tried manually changing these passwords in the database , for example, passw0rd, and everything worked fine

@USA-RedDragon
Copy link
Owner

USA-RedDragon commented Nov 18, 2023

The function I understand is that calls can only be received in the same talkgroup

This is how it should work, but since you said this, it doesn't sound like it:

The current situation is that after a client makes a call to any call group, other clients can receive a call even if they are not in the same talkgroup

I'll look into this, thanks for letting me know.

I tried to add and delete the repeater once to get a password that could be supported, but found that the special symbol would cause MMDVmhost to stop working. For example, a password that contains @%&* characters

Same here, I'll look into this. You wouldn't happen to have any logs from when this happened, would you?

@USA-RedDragon
Copy link
Owner

USA-RedDragon commented Nov 19, 2023

Looks like since about 2020, MMDVMHost wants folks to use DMRGateway for connecting to master servers like DMRHub. This seems to be because MMDVM isn't just DMR, so the DMR bits specifically are now handled at the DMRGateway side, so technically that setup is unsupported on the MMDVMHost side: See related issue g4klx/MMDVMHost#651

As long as DMRGatway is working as expected, there's not much I can do about MMDVMHost on the DMRHub side.


I'm looking into the talkgroup issue now

@USA-RedDragon
Copy link
Owner

image

This is how I've set up two DMR MMDVM repeaters for testing with. It seems like the DMR data is going to the appropriate talkgroups only and aren't leaking into other talkgroups unless they dynamically link. It's possible I misunderstood something from your report though.

@bf2spy
Copy link
Author

bf2spy commented Nov 19, 2023 via email

@bf2spy
Copy link
Author

bf2spy commented Nov 19, 2023 via email

@USA-RedDragon
Copy link
Owner

I see, thanks for clarifying. I have a theory about why this might be happening, I'll update as I've got more info.

@USA-RedDragon
Copy link
Owner

USA-RedDragon commented Nov 26, 2023

I think I found the issue. The "subscription" goroutines that manage repeater data routing takes in a copy of the repeater's subscribed talkgroups when it begins and it doesn't get any updates afterward to inform it that the subscribed talkgroups have changed. I am working on a fix for that

@USA-RedDragon
Copy link
Owner

I believe this is fixed with b3ec90e but my 2nd mmdvm isn't activating right now to test it. That commit will be in v1.0.46 when it releases tonight after I pull in dependency updates.

@bf2spy
Copy link
Author

bf2spy commented Dec 17, 2023 via email

@bf2spy
Copy link
Author

bf2spy commented Dec 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants