Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify + provide examples [defense] #253

Open
lindsayplatt opened this issue Jun 13, 2017 · 0 comments
Open

simplify + provide examples [defense] #253

lindsayplatt opened this issue Jun 13, 2017 · 0 comments

Comments

@lindsayplatt
Copy link
Contributor

  • Common gotchas: it would be nice to have examples for the suggested functions to use instead (e.g., isTRUE() and assert_that()) to show how they would be implemented in a function. I got distracted because it wasn't immediately clear to me what those functions were doing or how I would implement them.
  • Fail conspicuously: like the comment above, it would be super useful to walk through examples of how to implement conditions - as it's a bit hard to conceptualize without seeing them within a function.
  • I really like the examples in Fail Informatively - but it took me a while to wrap my head around what they were doing because it used so many unfamiliar commands (tryCatch, switch, sprintf), some of which are not related to defensive programming. Maybe simplify so no one gets caught up trying to understand the function itself? Probably fine in the online tutorial since people can take some time, but in a live training might struggle with it.

Comes from #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant