Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: After simulation, the script logs are dumped which includes the PK #10

Open
snreynolds opened this issue Dec 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@snreynolds
Copy link
Member

Describe the bug

Hide the PK from being logged after successful simulation. Currently we get logged something like this:

Executing command: "forge" "script" "/Users/sara/Uniswap/contracts/script/deploy/Deploy-all.s.sol ...

where the --private-key is also logged. We should remove honestly all of these logs, and only if logs are requested by the user, then still show hidden input for the private key.

Expected Behavior

If a user requests the script to run with logs then we should hide the pk like --private-key=*******

To Reproduce

No response

Additional context

No response

@snreynolds snreynolds added the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant