Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move styling from javascript to css in RNAplot and fornac #19

Open
j-4 opened this issue Jun 6, 2019 · 1 comment
Open

move styling from javascript to css in RNAplot and fornac #19

j-4 opened this issue Jun 6, 2019 · 1 comment

Comments

@j-4
Copy link
Collaborator

j-4 commented Jun 6, 2019

RNAplot and fornac currently define many colors and other styling options within the javascript code. It would be much more universal, if we would move this information to the css styles.

E.g. color schemes could work like this:

<g class='rna basepairscheme'>
  ...
  <circle base_type='a' domain_type='r'>
    ...

and css:

.basepairscheme > circle.node[base_type="a"] {
color: red;
}
.domainscheme > circle.node[domain_type="r"] {
color: blue;
}

By exchanging the basepairscheme class to domainscheme class, we could color the circles efficiently without any javascript code. Customization of the colors could then be done in css.
Exceptions for this approach would be coloring by position or custom coloring.

@j-4
Copy link
Collaborator Author

j-4 commented Jun 6, 2019

This will also fix ViennaRNA/forna#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant