Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main part still white #3

Open
morristai opened this issue Jan 20, 2019 · 15 comments
Open

main part still white #3

morristai opened this issue Jan 20, 2019 · 15 comments
Labels
bug Something isn't working issues Just issues

Comments

@morristai
Copy link

Hi, thanks for making such great theme, but when I apply to JDownloader using both method I got this result. Is there something I missed or it's a bug?

screenshot from 2019-01-21 03-04-56

@glubsy
Copy link

glubsy commented Jan 22, 2019

I think this is because you need to configure these colors separately, as they are not part of the theme or something. Edit: they are part of the jd cfg under ~/.jd/cfg see below!

Go to Settings -> Advanced Settings -> type "color" in the filter and edit the values manually.

Here's a screenshot of my settings for example (only changed the values with the yellow arrows):
screenshot

Also big thanks to @Vinylwalk3r for sharing this modified theme, it looks great. These stupid candy bar progress bars were atrocious. ;)

@morristai
Copy link
Author

@glubsy Thanks for the clear answer.

@Vinylwalk3r
Copy link
Owner

Hi, thanks for making such great theme, but when I apply to JDownloader using both method I got this result. Is there something I missed or it's a bug?

screenshot from 2019-01-21 03-04-56

Actually, darking that space is just what my theme does. Why you dont have it is a mystery 🤔 Am I right saying you are on Mac? that looks like a Mac or some Linux flavour. Seems strange if its not working on non-windows systems. I can only think of you missing something or dropping a folder somewhere by accident...Me thinks an investigation is in order 😏

@glubsy
Copy link

glubsy commented Jan 22, 2019

I forgot to mention that in my case, I only installed by copying the modified .jar file, and I didn't copy over the config files located there: https://github.com/Vinylwalk3r/JDownloader-2-Dark-Theme/tree/master/config/cfg

So that's what was missing, and it's probably what was the problem in the first place. Sorry about that!

@Vinylwalk3r
Copy link
Owner

Its nothin @glubsy . Glad it worked out! Enjoy ya new dark theme matie!

@Vinylwalk3r Vinylwalk3r added the question Further information is requested label Feb 14, 2019
@morristai
Copy link
Author

@Vinylwalk3r Sorry for the late reply. I'm using Ubuntu 18.10 btw. Apply this theme directly from the JDownloader setting section.

@PaulinoRBJ
Copy link

I'm not able to understand how to copy the config files. Can someone help me out?

@MO35AB
Copy link

MO35AB commented Dec 9, 2019

For me the title bar is still in white color, even though my windows is set to dark, windows explorer has a black title bar, any help ?

@Vinylwalk3r
Copy link
Owner

For me the title bar is still in white color, even though my windows is set to dark, windows explorer has a black title bar, any help ?

Screenshot? Is it only when the window is out of focus?

@MO35AB
Copy link

MO35AB commented Dec 9, 2019

image

here

@Vinylwalk3r
Copy link
Owner

Ah, that one. I can honestly say, since it is a Windows thing, I never even thought of touching it. Mine behaves the same, whenever out of focus, it goes white. Haven't found any settings for that behaviour, so I guess its a Windows + JD2 thing...
As much as I hate to say it, it's probably something we'll just have to live with.

@MO35AB
Copy link

MO35AB commented Dec 10, 2019

sorry, i thought i was clear, its the same as you @adamkkkkkk, white in both active and not active.

@Vinylwalk3r
Copy link
Owner

sorry, i thought i was clear, its the same as you @adamkkkkkk, white in both active and not active.

@MO35AB So I figured it out how the dev got a dark title bar for jd2 in those demo screenshots. It's by making the title bar colored via Windows settings as you can see in this screenshot. And I have the same problem as him too about jd2 not having a dark title bar when it's not in the foreground (while it's inactive).

2019-12-11_023354
2019-12-11_023406

Good work @adamkkkkkk! One question though, how did you get all those settings available in the Settings? I was investigating the same train of thought as you, but this is all I found:
Capture
Got no idea why our settings dont show the same controls....

But I godda say, good work figuring it out! (Also, sorry for not getting your question really there @MO35AB , your not talking to the sharpest tool in the shed..)

@Vinylwalk3r Vinylwalk3r added issues Just issues bug Something isn't working help wanted Extra attention is needed and removed question Further information is requested help wanted Extra attention is needed labels Jan 28, 2020
@fr0z3night
Copy link

enable setting 'LAF Settings: Window Decoration'

@Hasselshoff
Copy link

Just downloaded the Black Eye theme today and experienced this exact issue. Thanks to @fr0z3night I was able to correct it by enabling the 'LAF Settings: Window Decoration' option in Advanced Settings.

Interestingly, the 'LAF Settings: Window Decoration' option resets to false every time I restart JDownloader2 using the menu bar (File -> Restart), but the setting stays how I left it if I fully exit and start the program again. Not an issue really, since I can just avoid using the Restart feature, but does anyone know why restarting this way is causing the aforementioned setting to reset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issues Just issues
Projects
None yet
Development

No branches or pull requests

7 participants