You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PawelLipski opened this issue
Apr 2, 2024
· 0 comments
Labels
gitlabRelates to integration with GitLabminorAn annoyance, but not serioususabilityRelates to user experience, clarity, learning curve, reducing confusion etc.
For GitHub, POST/PATCH requests against a renamed repository end up in a 307 redirect, which isn't automatically followed by urllib. Such responses are then handled by extracting the new URL from Location header: see git_machete.github.GitHubClient.__fire_github_api_request.
For GitLab, such requests end up in a HTTP 405 (Method Not Allowed) response with {"message":"Non GET methods are not allowed for moved projects"} body. The new location can't be extracted from this response (no Location header returned); another GET /projects/... request is necessary.
This case is so rare that as for now (PR #1189, initial release of GitLab integration) we're not implementing it yet. We're just adding an error message in code that points to this exact issue. If you ever come it across, pls comment on this issue.
The text was updated successfully, but these errors were encountered:
PawelLipski
added
minor
An annoyance, but not serious
usability
Relates to user experience, clarity, learning curve, reducing confusion etc.
gitlab
Relates to integration with GitLab
labels
Apr 2, 2024
gitlabRelates to integration with GitLabminorAn annoyance, but not serioususabilityRelates to user experience, clarity, learning curve, reducing confusion etc.
For GitHub, POST/PATCH requests against a renamed repository end up in a 307 redirect, which isn't automatically followed by urllib. Such responses are then handled by extracting the new URL from
Location
header: seegit_machete.github.GitHubClient.__fire_github_api_request
.For GitLab, such requests end up in a HTTP 405 (Method Not Allowed) response with
{"message":"Non GET methods are not allowed for moved projects"}
body. The new location can't be extracted from this response (noLocation
header returned); anotherGET /projects/...
request is necessary.This case is so rare that as for now (PR #1189, initial release of GitLab integration) we're not implementing it yet. We're just adding an error message in code that points to this exact issue. If you ever come it across, pls comment on this issue.
The text was updated successfully, but these errors were encountered: