Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement database ID search #6

Open
jimhavrilla opened this issue Mar 13, 2020 · 4 comments
Open

Implement database ID search #6

jimhavrilla opened this issue Mar 13, 2020 · 4 comments

Comments

@jimhavrilla
Copy link
Collaborator

Can be a partial ID (e.g. LIKE searching in SQLite) and can be HPO id, OMIM, etc.

In query search on website make the option no longer say "Search by HPO ID" but instead say "Search by external database ID (e.g., OMIM, HPO, UMLS, etc.)"

@jimhavrilla
Copy link
Collaborator Author

@shawnxd every time I tried a full OR partial ID search I got this error:
image
I recommend fixing the ID search implementation soon.

@jimhavrilla
Copy link
Collaborator Author

On discussions with Cong and realizing how unlikely this is to actually be used, I think we'll close this. In the future it may be incorporated via elastic search if it is something people really want.

@jimhavrilla
Copy link
Collaborator Author

While this is no longer really important, with ElasticSearch, it is something that can be relatively easily done. A lot depends on string search though, so the user would have to specify they want this.

@jimhavrilla
Copy link
Collaborator Author

I think this can now be done. Something to think about, doesn't necessarily need autocompletion but could be good to have the searchability. Database abbrev:ID for search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants