Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer is Stuck Below Viewport #3

Open
pettazz opened this issue Sep 7, 2013 · 1 comment
Open

Footer is Stuck Below Viewport #3

pettazz opened this issue Sep 7, 2013 · 1 comment
Assignees
Labels

Comments

@pettazz
Copy link
Member

pettazz commented Sep 7, 2013

When content is not long enough to push #wrap below the viewport bottom, the footer's top edge still starts at the bottom edge of the viewport, so it's hidden unless the page is scrolled down. This looks ridiculous on pages like search with no results, or anything with short content in either #postGrid or .content-main.

@ghost ghost assigned pettazz Sep 7, 2013
@pettazz
Copy link
Member Author

pettazz commented Sep 7, 2013

#wrap uses min-height: 100% to ensure the footer doesn't creep up to the bottom edge of content, which always pushes it to exactly past the bottom of the viewport. Changing margins within #wrap and footer will only trade between off-viewport and creeping up -70px into content. Also, pages with Disqus may start with height less than viewport, but once Disqus is rendered, will probably expand to be longer, so changes to footer's positioning have to be CSS-based, or intelligent enough to respond on any content change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant