Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes without translation functions fails the text domain check #413

Open
carolinan opened this issue Jan 4, 2022 · 2 comments
Open

Themes without translation functions fails the text domain check #413

carolinan opened this issue Jan 4, 2022 · 2 comments

Comments

@carolinan
Copy link
Collaborator

It is possible to have a block theme without translation functions, for example if the text strings are in the HTML templates.

The error message is:
REQUIRED: This theme text domain does not match the theme's slug. The text domain used: This theme's correct slug and text-domain is kubrick2.

The text domain is missing in the message above.

@kafleg
Copy link
Member

kafleg commented Jan 4, 2022

Do you mean to ignore this message for block themes?

@carolinan
Copy link
Collaborator Author

No, I mean to not fail if a text domain is never used.

Block themes that has translation functions anywhere should still be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants