(fix) Pass strings to scilla as strings, rather than arrays of their bytes #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(note that I don't allege that this is the right fix - just that it works for my use case!) |
|
Bencher Report| Branch | users/richard/2163-passing-strings-to-scilla |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8.46 (-7.96%) | 10.37 (81.63%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,854.20 (-5.75%) | 2,287.42 (81.06%) |
|
Would a transaction have been able to be mined with the previous behaviour? If so, we need to conditionalise this with fork configuration. |
I don't believe so - the old code returned an array of bytes; if you could find an array of bytes which was valid JSON, then potentially yes, but I can't think of one. Happy either way, though - let me know if you want to add it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2163