Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered behaviour of GetTransactionStatus #2170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxconway
Copy link
Contributor

I'm very open to different logic if anyone knows better exactly what the behaviour should be here.

Intended to fix #2167

@maxconway maxconway linked an issue Jan 17, 2025 that may be closed by this pull request
@maxconway maxconway self-assigned this Jan 17, 2025
@maxconway maxconway marked this pull request as ready for review January 17, 2025 16:06
@maxconway maxconway enabled auto-merge January 17, 2025 16:07
Copy link
Contributor

🐰 Bencher Report

Branchmax/fix/2167-incorrect-status-returned-by-gettransactionstatus
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
process-empty/process-empty📈 view plot
🚷 view threshold
7.56
(-17.19%)
10.47
(72.24%)
produce-full/produce-full📈 view plot
🚷 view threshold
2,185.40
(+10.56%)
2,300.36
(95.00%)
🐰 View full continuous benchmarking report in Bencher

@maxconway
Copy link
Contributor Author

See discussion in #2167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect status returned by GetTransactionStatus
1 participant