Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Don't use view controller appearance methods for managing notification subscription #1

Open
odnoletkov opened this issue Jun 10, 2019 · 1 comment

Comments

@odnoletkov
Copy link

  1. UIKit doesn't guarantee specific order or paring for viewDidAppear and viewDidDisappear (as well as for most other appearance methods combinations). So they can't be used for proper management of the notification lifecycle and can cause over- or under-subscription problems in practice.
  2. Why the safe area update shouldn't happen when view is 'disappeared' in the first place?
@a2
Copy link
Owner

a2 commented Jun 11, 2019

This is great feedback! Thanks so much, @odnoletkov, for pointing it out. I'd gladly accept a PR that fixes this issue. Is that something you could provide? I might be able to do it myself but no guarantees on timeframe since I'm working this week :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants