From 6932006408200435ae25d9035b753404989bd193 Mon Sep 17 00:00:00 2001 From: Keshav Priyadarshi Date: Tue, 30 Sep 2025 16:48:39 +0530 Subject: [PATCH] Use urljoin to construct catalog URLs Signed-off-by: Keshav Priyadarshi --- sync_catalog.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sync_catalog.py b/sync_catalog.py index d64200e4f..33984eedd 100644 --- a/sync_catalog.py +++ b/sync_catalog.py @@ -10,6 +10,7 @@ from datetime import datetime from datetime import timezone from pathlib import Path +from urllib.parse import urljoin import requests @@ -34,7 +35,7 @@ def steps(cls): def check_new_catalog(self): start_page = self.get_catalog_page_count() - self.fetch_and_write(f"{self.url}/index.json", CATALOG_INDEX) + self.fetch_and_write(urljoin(self.url, "index.json"), CATALOG_INDEX) end_page = self.get_catalog_page_count() self.pages_to_collect = range(start_page, end_page) @@ -47,10 +48,10 @@ def collect_new_catalog(self): logger=self.log, ) for page in progress.iter(latest_pages): - page_id = f"page{page}" + page_id = f"page{page}.json" self.fetch_and_write( - url=f"{self.url}{page_id}.json", - path=PAGE_DIRECTORY / f"{page_id}.json", + url=urljoin(self.url, page_id), + path=PAGE_DIRECTORY / page_id, ) def log(self, message):