add missing distinct on filter

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

product_portfolio/api.py

@@ -211,6 +211,7 @@ class ProductFilterSet(DataspacedAPIFilterSet):
     has_reachable_vulnerability = django_filters.BooleanFilter(
         field_name="vulnerability_analyses__is_reachable",
         label="Has reachable vulnerability",
+        distinct=True,
     )
 
     class Meta:
@@ -893,6 +894,7 @@ class ProductPackageFilterSet(DataspacedAPIFilterSet):
     has_reachable_vulnerability = django_filters.BooleanFilter(
         field_name="vulnerability_analyses__is_reachable",
         label="Has reachable vulnerability",
+        distinct=True,
     )
 
     class Meta:

product_portfolio/tests/test_api.py

@@ -1582,6 +1582,28 @@ def test_api_product_has_reachable_vulnerability_filter(self):
         response = self.client.get(self.product_list_url, data)
         self.assertEqual(0, response.data["count"])
 
+    def test_api_product_has_reachable_vulnerability_filter_no_duplicates(self):
+        self.client.login(username="super_user", password="secret")
+        vulnerability1 = make_vulnerability(self.dataspace, affecting=self.package1)
+        vulnerability2 = make_vulnerability(self.dataspace, affecting=self.package1)
+        make_vulnerability_analysis(self.pp1, vulnerability1, is_reachable=True)
+        make_vulnerability_analysis(self.pp1, vulnerability2, is_reachable=True)
+
+        data = {"has_reachable_vulnerability": "true"}
+        response = self.client.get(self.product_list_url, data)
+        self.assertEqual(1, response.data["count"])
+
+    def test_api_productpackage_has_reachable_vulnerability_filter_no_duplicates(self):
+        self.client.login(username="super_user", password="secret")
+        vulnerability1 = make_vulnerability(self.dataspace, affecting=self.package1)
+        vulnerability2 = make_vulnerability(self.dataspace, affecting=self.package1)
+        make_vulnerability_analysis(self.pp1, vulnerability1, is_reachable=True)
+        make_vulnerability_analysis(self.pp1, vulnerability2, is_reachable=True)
+
+        data = {"has_reachable_vulnerability": "true"}
+        response = self.client.get(self.productpackage_list_url, data)
+        self.assertEqual(1, response.data["count"])
+
     def test_api_codebaseresource_list_endpoint_results(self):
         self.client.login(username="super_user", password="secret")
         response = self.client.get(self.codebase_resource_list_url)