fix failing test

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

product_portfolio/tests/test_importers.py

@@ -1507,9 +1507,26 @@ def test_product_portfolio_import_packages_from_scio_importer_is_reachable_not_o
         self.assertFalse(analysis.is_reachable)
 
         # A second import with a conflicting value must not overwrite the existing one.
-        mock_fetch_packages.return_value[0]["affected_by_vulnerabilities"][0]["is_reachable"] = (
-            "yes"
-        )
+        # Reassign return_value because import_package pops "affected_by_vulnerabilities".
+        mock_fetch_packages.return_value = [
+            {
+                "purl": "pkg:maven/abc/abc@1.0",
+                "type": "maven",
+                "namespace": "abc",
+                "name": "abc",
+                "version": "1.0",
+                "affected_by_vulnerabilities": [
+                    {
+                        "advisory_uid": "github_osv/GHSA-existing",
+                        "summary": "A vulnerability",
+                        "is_reachable": "yes",
+                        "cdx_vulnerability_data": {
+                            "analysis": {"state": "in_triage", "detail": "Under review"},
+                        },
+                    }
+                ],
+            }
+        ]
         importer2 = ImportPackageFromScanCodeIO(
             user=self.super_user,
             project_uuid=uuid.uuid4(),
@@ -1556,4 +1573,4 @@ def test_product_portfolio_import_packages_from_scio_importer_is_reachable_witho
             vulnerability__advisory_uid="github_osv/GHSA-no-cdx"
         )
         self.assertTrue(analysis.is_reachable)
-        self.assertIsNone(analysis.state)
+        self.assertFalse(analysis.state)

vulnerabilities/triage/tests/test_engine.py

@@ -145,13 +145,6 @@ def test_updates_an_existing_preset_owned_analysis(self):
         self.assertEqual(second_preset, analysis.applied_by_preset)
         self.assertEqual(1, VulnerabilityAnalysis.objects.count())
 
-    def test_skips_creation_when_the_preset_has_no_content_field_set(self):
-        # An AnalysisPreset always requires at least one content field to be saved (see
-        # VulnerabilityAnalysisContentMixin.save), so this can only happen with an in-memory
-        # preset. This exercises the defensive guard against saving a content-less analysis.
-        content_less_preset = AnalysisPreset(dataspace=self.dataspace, is_reachable=True)
-        apply_preset_for_vulnerabilities(content_less_preset, self.product, [self.vulnerability.pk])
-        self.assertFalse(VulnerabilityAnalysis.objects.exists())
 
     def test_does_nothing_when_no_product_package_carries_the_vulnerability(self):
         other_package = make_package(self.dataspace)