Skip to content

Commit 55a3679

Browse files
committed
refining logging
Signed-off-by: tdruez <tdruez@aboutcode.org>
1 parent f48d426 commit 55a3679

1 file changed

Lines changed: 18 additions & 15 deletions

File tree

product_portfolio/importers.py

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,14 @@
5454
logger = logging.getLogger(__name__)
5555

5656

57+
@contextmanager
58+
def log_elapsed(label):
59+
"""Context manager that logs the elapsed time of the wrapped block."""
60+
start = time.perf_counter()
61+
yield
62+
logger.info(f"{label}: {time.perf_counter() - start:.1f}s")
63+
64+
5765
class CleanProductMixin(ComponentRelatedFieldImportMixin):
5866
def clean_product(self):
5967
queryset = Product.objects.get_queryset(self.user)
@@ -701,35 +709,30 @@ def save(self):
701709

702710
scancodeio = ScanCodeIO(self.dataspace)
703711

704-
step_start = time.perf_counter()
705-
self.packages = scancodeio.fetch_project_packages(self.project_uuid)
706-
logger.info(f"fetch_project_packages: {time.perf_counter() - step_start:.1f}s")
712+
with log_elapsed("fetch_project_packages"):
713+
self.packages = scancodeio.fetch_project_packages(self.project_uuid)
707714

708715
if not self.packages:
709716
raise Exception("Packages could not be fetched from ScanCode.io")
710717

711718
if self.create_dependencies:
712-
step_start = time.perf_counter()
713-
self.dependencies = scancodeio.fetch_project_dependencies(self.project_uuid)
714-
logger.info(f"fetch_project_dependencies: {time.perf_counter() - step_start:.1f}s")
719+
with log_elapsed("fetch_project_dependencies"):
720+
self.dependencies = scancodeio.fetch_project_dependencies(self.project_uuid)
715721

716-
step_start = time.perf_counter()
717-
self.import_packages()
718-
logger.info(f"import_packages: {time.perf_counter() - step_start:.1f}s")
722+
with log_elapsed("import_packages"):
723+
self.import_packages()
719724

720725
if self.create_dependencies:
721-
step_start = time.perf_counter()
722-
self.import_dependencies()
723-
logger.info(f"import_dependencies: {time.perf_counter() - step_start:.1f}s")
726+
with log_elapsed("import_dependencies"):
727+
self.import_dependencies()
724728

725729
if self.scan_all_packages:
726730
transaction.on_commit(lambda: self.product.scan_all_packages_task(self.user))
727731
logger.info("scan_all_packages: scheduled")
728732

729733
if self.user.dataspace.enable_vulnerablecodedb_access:
730-
step_start = time.perf_counter()
731-
self.product.fetch_vulnerabilities()
732-
logger.info(f"fetch_vulnerabilities: {time.perf_counter() - step_start:.1f}s")
734+
with log_elapsed("fetch_vulnerabilities"):
735+
self.product.fetch_vulnerabilities()
733736

734737
logger.info(f"save total: {time.perf_counter() - save_start:.1f}s")
735738

0 commit comments

Comments
 (0)