Skip to content

Commit 887e2c6

Browse files
committed
change exclusion logic
Signed-off-by: tdruez <tdruez@aboutcode.org>
1 parent d4d81ba commit 887e2c6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

policy/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def evaluate_all_products_rules_task(include_locked=False, product_uuids=None):
4848
products = get_unsecured_manager(Product).select_related("dataspace")
4949
if product_uuids is not None:
5050
products = products.filter(uuid__in=product_uuids)
51-
elif not include_locked:
51+
if not include_locked:
5252
products = products.exclude(configuration_status__is_locked=True)
5353

5454
count = products.count()

policy/tests/test_tasks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def test_evaluate_all_products_filters_by_uuids(self, mock_evaluate):
127127
self.assertNotIn(product_b, evaluated_products)
128128

129129
@patch("policy.tasks.evaluate_rules")
130-
def test_evaluate_all_products_uuid_filter_ignores_locked_exclusion(self, mock_evaluate):
130+
def test_evaluate_all_products_uuid_filter_still_excludes_locked(self, mock_evaluate):
131131
mock_evaluate.return_value = ([], 0)
132132
locked_status = make_product_status(self.dataspace, is_locked=True)
133133
locked_product = make_product(self.dataspace, configuration_status=locked_status)
@@ -136,4 +136,4 @@ def test_evaluate_all_products_uuid_filter_ignores_locked_exclusion(self, mock_e
136136
evaluate_all_products_rules_task(product_uuids=[locked_product.uuid])
137137

138138
evaluated_products = [c[0][0] for c in mock_evaluate.call_args_list]
139-
self.assertIn(locked_product, evaluated_products)
139+
self.assertNotIn(locked_product, evaluated_products)

0 commit comments

Comments
 (0)