Skip to content

Commit a28d351

Browse files
authored
Truncate the display of very long PURLs #227 (#248)
Signed-off-by: tdruez <tdruez@nexb.com>
1 parent 0057531 commit a28d351

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

component_catalog/templates/component_catalog/tables/package_list_table.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@
3030
{% endif %}
3131
</ul>
3232
<strong>
33-
<a href="{% inject_preserved_filters object.details_url %}">{{ object }}</a>
33+
<a href="{% inject_preserved_filters object.details_url %}"{% if object.identifier|length > 100 %} title="{{ object.identifier }}"{% endif %}>
34+
{{ object.identifier|truncatechars:100 }}
35+
</a>
3436
</strong>
3537
{% if filter.show_created_date %}
3638
<div class="smaller text-muted-darker" title="{{ object.created_date|date:'N j, Y, f A' }}">Created {{ object.created_date|naturaltime_short }}</div>

component_catalog/tests/test_views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,8 +1173,8 @@ def test_package_views_urls(self):
11731173
def test_package_list_view_content(self):
11741174
self.client.login(username=self.super_user.username, password="secret")
11751175
response = self.client.get(reverse("component_catalog:package_list"))
1176-
self.assertContains(response, self.package1.get_absolute_link())
1177-
self.assertContains(response, self.package2.get_absolute_link())
1176+
self.assertContains(response, self.package1.get_absolute_link(), html=True)
1177+
self.assertContains(response, self.package2.get_absolute_link(), html=True)
11781178
self.assertContains(response, self.component1)
11791179
self.assertContains(response, self.component2)
11801180

dje/templates/object_details_base.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
</div>
2222
<h1 class="header-title text-break">
2323
{% block header_title %}
24-
{{ object }}
24+
{{ object|truncatechars:100 }}
2525
<small class="ms-1" style="font-size: 70%">
2626
{% if is_user_dataspace %}
2727
{% if has_change_permission %}

0 commit comments

Comments
 (0)