rework the implementation

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

product_portfolio/importers.py

@@ -839,11 +839,16 @@ def import_vulnerability(vulnerability_data, product_package):
             is_reachable = False
 
         if is_reachable is not None:
-            VulnerabilityAnalysis.objects.filter(
+            analysis, created = VulnerabilityAnalysis.objects.get_or_create(
                 product_package=product_package,
                 vulnerability=vulnerability,
-                is_reachable__isnull=True,
-            ).update(is_reachable=is_reachable)
+                dataspace=product_package.dataspace,
+                defaults={"is_reachable": is_reachable},
+            )
+            if not created and analysis.is_reachable is None:
+                VulnerabilityAnalysis.objects.filter(pk=analysis.pk).update(
+                    is_reachable=is_reachable
+                )
 
     def import_package(self, package_data):
         # Vulnerabilities are assigned after the package creation.

vulnerabilities/models.py

@@ -584,6 +584,9 @@ class Meta:
     def __str__(self):
         return f"{self.vulnerability} analysis"
 
+    def has_content_fields(self):
+        return super().has_content_fields() or self.is_reachable is not None
+
     def save(self, *args, **kwargs):
         """Set the product and package fields values from the product_package FK."""
         self.product_id = self.product_package.product_id