add unit test coverage

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

dje/tests/test_forms.py

@@ -110,7 +110,7 @@ def test_tabs_permission_formset_load_perms(self):
 
     def test_copy_defaults_form_get_all_dataspaced_models(self):
         dataspaced_models = CopyDefaultsForm.get_all_dataspaced_models()
-        self.assertEqual(10, len(dataspaced_models))
+        self.assertEqual(11, len(dataspaced_models))
         self.assertEqual(7, len(dataspaced_models.get("Component Catalog")))
         self.assertIn("Subcomponent", str(dataspaced_models.get("Component Catalog")))
 

product_portfolio/tests/test_views.py

@@ -64,6 +64,9 @@
 from vulnerabilities.models import VulnerabilityAnalysis
 from vulnerabilities.tests import make_vulnerability
 from vulnerabilities.tests import make_vulnerability_analysis
+from vulnerabilities.triage.models import ProductTriageRuleset
+from vulnerabilities.triage.models import TriageAction
+from vulnerabilities.triage.models import TriageRuleset
 from workflow.models import Request
 from workflow.models import RequestTemplate
 
@@ -298,6 +301,18 @@ def test_product_portfolio_detail_view_tab_vulnerability_queryset(self):
 
     def test_product_portfolio_tab_vulnerability_view_filters(self):
         self.client.login(username="nexb_user", password="secret")
+        # The "Recommendation" column, and its triage_action filter, only render when the
+        # product has at least one enabled TriageRuleset assigned to it.
+        ruleset = TriageRuleset.objects.create(
+            name="Upgrade Ruleset",
+            action=TriageAction.UPGRADE,
+            precedence=100,
+            dataspace=self.dataspace,
+        )
+        ProductTriageRuleset.objects.create(
+            product=self.product1, ruleset=ruleset, dataspace=self.dataspace
+        )
+
         url = self.product1.get_url("tab_vulnerabilities")
         response = self.client.get(url)
         self.assertContains(response, "?vulnerabilities-triage_action=#vulnerabilities")

vulnerabilities/triage/tests/__init__.py

@@ -0,0 +1,59 @@
+#
+# Copyright (c) nexB Inc. and others. All rights reserved.
+# DejaCode is a trademark of nexB Inc.
+# SPDX-License-Identifier: AGPL-3.0-only
+# See https://github.com/aboutcode-org/dejacode for support or download.
+# See https://aboutcode.org for more information about AboutCode FOSS projects.
+#
+
+import random
+
+from dje.tests import make_string
+from vulnerabilities.triage.models import AnalysisPreset
+from vulnerabilities.triage.models import ProductTriageRuleset
+from vulnerabilities.triage.models import TriageRuleset
+
+
+def make_triage_ruleset(dataspace, **data):
+    """Create a TriageRuleset for test purposes."""
+    if "name" not in data:
+        data["name"] = f"ruleset-{make_string(10)}"
+
+    if "precedence" not in data:
+        # `precedence` is unique per dataspace: randomize the default so tests creating
+        # several rulesets without an explicit precedence do not collide with each other.
+        data["precedence"] = random.randint(1, 1_000_000)
+
+    return TriageRuleset.objects.create(
+        dataspace=dataspace,
+        **data,
+    )
+
+
+def make_analysis_preset(dataspace, **data):
+    """Create an AnalysisPreset for test purposes."""
+    if "name" not in data:
+        data["name"] = f"preset-{make_string(10)}"
+
+    if not any(data.get(field) for field in ("state", "justification", "responses", "detail")):
+        data["state"] = AnalysisPreset.State.NOT_AFFECTED
+
+    return AnalysisPreset.objects.create(
+        dataspace=dataspace,
+        **data,
+    )
+
+
+def make_product_triage_ruleset(product, ruleset=None, **data):
+    """Activate a TriageRuleset for the given product."""
+    dataspace = product.dataspace
+
+    if not ruleset:
+        ruleset = make_triage_ruleset(dataspace)
+
+    return ProductTriageRuleset.objects.create(
+        product=product,
+        ruleset=ruleset,
+        dataspace=dataspace,
+        **data,
+    )