Remove all password recommendations.

Add a function to retrieve the vulnerabilities file path using vulnerability ID.

Signed-off-by: ziad hany <ziadhany2016@gmail.com>

Author: ziadhany

fedcode/pipes/utils.py

@@ -8,6 +8,7 @@
 #
 
 import json
+import os
 
 import saneyaml
 from packageurl import PackageURL
@@ -95,3 +96,22 @@ def get_scan_note(path):
             },
         ],
     }
+
+
+def get_vulnerability_path(repo_path: str, vulnerability_id: str) -> str:
+    """
+    Get the vulnerability file path using repo_path and vulnerability_id.
+    Raise FileNotFoundError if the file does not exist.
+    """
+    vul_filepath = os.path.join(
+        repo_path,
+        f"aboutcode-vulnerabilities-{vulnerability_id[5:7]}",
+        vulnerability_id[10:12],
+        vulnerability_id,
+        f"{vulnerability_id}.yml",
+    )
+
+    if not os.path.exists(vul_filepath):
+        raise FileNotFoundError(f"Vulnerability file not found: {vul_filepath}")
+
+    return vul_filepath

fedcode/templates/user_sign_up.html

@@ -29,45 +29,39 @@
     </div>
     {% endif %}
 
-    <h2 class="title">User Signup</h2>
+    <h2 class="title">Create your FederatedCode Account</h2>
     <form method="post">
       {% csrf_token %}
       <div class="field">
         <div class="control">
-          <input class="input" placeholder="Username" type="text" name="username" maxlength="150" autofocus required
+            <label class="label" for="id_username">Username</label>
+            <input class="input" placeholder="Username" type="text" name="username" maxlength="150" autofocus required
             id="id_username">
-          <span class="help">
-            Only letters, numbers, and <strong>@ . + - _</strong> allowed.
-          </span>
         </div>
       </div>
       <div class="field">
         <div class="control">
+          <label class="label" for="id_email">Email</label>
           <input class="input" type="email" placeholder="Email" name="email" maxlength="254" required id="id_email">
         </div>
       </div>
       <div class="field">
         <div class="control">
-          <input class="input" type="password" placeholder="Password" name="password1" autocomplete="new-password"
+            <label class="label" for="id_password1">Password</label>
+            <input class="input" type="password" placeholder="Create a password" name="password1" autocomplete="new-password"
             required id="id_password1">
-          <span class="help">
-            <ul>
-              <li>Password can't be too similar to your other personal information.</li>
-              <li>Password must contain at least 8 characters.</li>
-              <li>Password can't be a commonly used password.</li>
-              <li>Password can't be entirely numeric.</li>
-            </ul>
-          </span>
 
         </div>
       </div>
       <div class="field">
         <div class="control">
-          <input class="input" type="password" placeholder="Confirm password" name="password2"
+          <label class="label" for="id_password2">Confirm Password</label>
+          <input class="input" type="password" placeholder="Confirm your password" name="password2"
             autocomplete="new-password" required id="id_password2">
         </div>
       </div>
       <div class="field">
+        <label class="label">Verification</label>
         <div class="control">
           {{ form.captcha }}
         </div>

fedcode/views.py

@@ -68,6 +68,7 @@
 from fedcode.models import Review
 from fedcode.models import SyncRequest
 from fedcode.models import Vulnerability
+from fedcode.pipes.utils import get_vulnerability_path
 from fedcode.signatures import FEDERATEDCODE_PUBLIC_KEY
 from fedcode.signatures import HttpSignature
 from fedcode.utils import ap_collection
@@ -810,16 +811,17 @@ def redirect_repository(request, repository_id):
 def redirect_vulnerability(request, vulnerability_id):
     try:
         vul = Vulnerability.objects.get(id=vulnerability_id)
-        vul_filepath = os.path.join(
-            vul.repo.path,
-            f"./aboutcode-vulnerabilities-{vulnerability_id[5:7]}/{vulnerability_id[10:12]}"
-            f"/{vulnerability_id}/{vulnerability_id}.yml",
-        )
-        with open(vul_filepath) as f:
-            return HttpResponse(json.dumps(f.read()))
+
+        repo_path = vul.repo.path
+        vul_filepath = get_vulnerability_path(repo_path, vulnerability_id)
+
+        with open(vul_filepath, encoding="utf-8") as f:
+            return HttpResponse(json.dumps(f.read()), content_type="application/json")
 
     except Vulnerability.DoesNotExist:
-        return Http404("Vulnerability does not exist")
+        raise Http404("Vulnerability does not exist")
+    except FileNotFoundError:
+        raise Http404("Vulnerability file not found")
 
 
 class UserFollowing(View):