Skip to content

Commit bf7d3a6

Browse files
committed
Address review comments
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent c7d7e28 commit bf7d3a6

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

src/python_inspector/resolution.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def get_requirements_from_distribution(handler, location):
6060
return []
6161
deps = list(handler.parse(location))
6262
assert len(deps) == 1
63-
return list(get_requirements_from_dependencies(deps[0].dependencies))
63+
return list(get_requirements_from_dependencies(dependencies=deps[0].dependencies))
6464

6565

6666
def is_requirements_file_in_setup_files(setup_files):
@@ -210,7 +210,7 @@ def get_versions_for_package_from_repo(self, name, repo):
210210
versions = []
211211
for version, package in repo.get_package_versions(name).items():
212212
python_version = packaging.version.parse(
213-
get_python_version_from_env_tag(self.environment.python_version)
213+
get_python_version_from_env_tag(python_version=self.environment.python_version)
214214
)
215215
wheels = list(package.get_supported_wheels(environment=self.environment))
216216
if wheels:
@@ -253,7 +253,7 @@ def get_requirements_for_package_from_pypi_simple(self, candidate):
253253
Return requirements for a package from the simple repositories.
254254
"""
255255
python_version = packaging.version.parse(
256-
get_python_version_from_env_tag(self.environment.python_version)
256+
get_python_version_from_env_tag(python_version=self.environment.python_version)
257257
)
258258

259259
wheels = utils_pypi.download_wheel(
@@ -343,25 +343,30 @@ def get_candidates(self, all_versions, requirements, identifier, bad_versions, n
343343
"""
344344
for version in all_versions:
345345
parsed_version = packaging.version.parse(version)
346-
if not is_valid_version(parsed_version, requirements, identifier, bad_versions):
346+
if not is_valid_version(
347+
parsed_version=parsed_version,
348+
requirements=requirements,
349+
identifier=identifier,
350+
bad_versions=bad_versions,
351+
):
347352
continue
348353
yield Candidate(name=name, version=parsed_version, extras=extras)
349354

350355
def _iter_matches(self, identifier, requirements, incompatibilities):
351356
"""
352357
Yield candidates for the given identifier, requirements and incompatibilities
353358
"""
354-
name = remove_extras(identifier)
359+
name = remove_extras(identifier=identifier)
355360
bad_versions = {c.version for c in incompatibilities[identifier]}
356361
extras = {e for r in requirements[identifier] for e in r.extras}
357362
if not self.repos:
358-
all_versions = self.get_versions_for_package(name)
363+
all_versions = self.get_versions_for_package(name=name)
359364
yield from self.get_candidates(
360365
all_versions, requirements, identifier, bad_versions, name, extras
361366
)
362367
else:
363368
for repo in self.repos:
364-
all_versions = self.get_versions_for_package(name, repo)
369+
all_versions = self.get_versions_for_package(name=name, repo=repo)
365370
yield from self.get_candidates(
366371
all_versions, requirements, identifier, bad_versions, name, extras
367372
)
@@ -395,15 +400,15 @@ def _iter_dependencies(self, candidate):
395400
version=str(candidate.version),
396401
)
397402

398-
for r in self.get_requirements_for_package(purl, candidate):
403+
for r in self.get_requirements_for_package(purl=purl, candidate=candidate):
399404
if r.marker is None:
400405
yield r
401406
else:
402407
if r.marker.evaluate(
403408
{
404409
"extra": "",
405410
"python_version": get_python_version_from_env_tag(
406-
self.environment.python_version
411+
python_version=self.environment.python_version
407412
),
408413
"platform_system": self.environment.operating_system.capitalize(),
409414
"sys_platform": self.environment.operating_system,

0 commit comments

Comments
 (0)