Skip to content

Commit c5d4423

Browse files
committed
Do not use a default global
using a function argument with default mutable collection is a problem Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent ccfe258 commit c5d4423

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/python_inspector/resolve_cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def resolve(
352352
Used the provided ``repos`` list of PypiSimpleRepository.
353353
If empty, use instead the PyPI.org JSON API exclusively.
354354
"""
355-
355+
356356
environment_marker = get_environment_marker_from_environment(environment)
357357

358358
requirements = list(
@@ -377,7 +377,7 @@ def resolve(
377377

378378

379379
def get_requirements_from_direct_dependencies(
380-
direct_dependencies: List[DependentPackage], environment_marker: Dict = {}
380+
direct_dependencies: List[DependentPackage], environment_marker: Dict
381381
) -> List[Requirement]:
382382
for dependency in direct_dependencies:
383383
# FIXME We are skipping editable requirements

tests/test_resolution.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test_without_supported_wheels():
145145
"pkg:pypi/hyperlink@21.0.0",
146146
"pkg:pypi/idna@3.3",
147147
"pkg:pypi/pycparser@2.21",
148-
"pkg:pypi/setuptools@64.0.1",
148+
"pkg:pypi/setuptools@65.0.0",
149149
"pkg:pypi/txaio@22.2.1",
150150
]
151151

0 commit comments

Comments
 (0)