Remove unreachable duplicate LGPL key in rubygems license mapping - #5315
Open
Daksha1611 wants to merge 1 commit into
Open
Remove unreachable duplicate LGPL key in rubygems license mapping#5315Daksha1611 wants to merge 1 commit into
Daksha1611 wants to merge 1 commit into
Conversation
…rg#5314 LICENSES_MAPPING defined 'LGPL' on two consecutive lines, so the first entry was silently discarded and a bare LGPL declaration always resolved to lgpl-2.0-plus. Remove the unreachable line and keep the value that already applies, so the mapping is unchanged at runtime. Signed-off-by: Daksha1611 <mehtadaksha1611@gmail.com>
Shriprasad-P
left a comment
Shriprasad-P
left a comment
There was a problem hiding this comment.
Review
PR: Remove unreachable duplicate LGPL key in rubygems license mapping
Touched: CHANGELOG.rst, src/packagedcode/rubygems.py
- CI/tooling change — confirm the pipeline still passes on this branch.
- Size looks manageable (+3/-1).
Commenting as a drive-by reviewer after reading the diff. Happy to look again if maintainers want a deeper pass on a specific file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5314
LICENSES_MAPPINGhas'LGPL'on two consecutive lines (679-680), so the first is discarded and a bareLGPLgem declaration always resolves tolgpl-2.0-plus.This drops the unreachable line and keeps the value that already applies, so nothing changes at runtime. As noted in the issue, it is worth deciding whether an unversioned
LGPLshould stay unversioned aslgplinstead — that is a one-word change on top of this if you want it.