add new behavior in ExportJSONMixin

Signed-off-by: tdruez <tdruez@aboutcode.org>

Author: tdruez

scanpipe/tests/test_views.py

@@ -1505,6 +1505,10 @@ def test_project_packages_export_json(self):
 
         self.assertIsInstance(response, FileResponse)
         self.assertEqual(response.get("Content-Type"), "application/json")
+        self.assertTrue(response.get("Content-Disposition").startswith("inline"))
+
+        with override_settings(SCANPIPE={"INLINE_DOWNLOAD_MAX_SIZE": 0}):
+            response = self.client.get(url + "?export_json=True")
         self.assertTrue(response.get("Content-Disposition").startswith("attachment"))
 
         file_content = b"".join(response.streaming_content).decode("utf-8")
@@ -1570,7 +1574,7 @@ def test_project_dependencies_export_json(self):
 
         self.assertIsInstance(response, FileResponse)
         self.assertEqual(response.get("Content-Type"), "application/json")
-        self.assertTrue(response.get("Content-Disposition").startswith("attachment"))
+        self.assertTrue(response.get("Content-Disposition").startswith("inline"))
 
         file_content = b"".join(response.streaming_content).decode("utf-8")
         json_data = json.loads(file_content)
@@ -1606,7 +1610,7 @@ def test_project_relations_export_json(self):
 
         self.assertIsInstance(response, FileResponse)
         self.assertEqual(response.get("Content-Type"), "application/json")
-        self.assertTrue(response.get("Content-Disposition").startswith("attachment"))
+        self.assertTrue(response.get("Content-Disposition").startswith("inline"))
 
         file_content = b"".join(response.streaming_content).decode("utf-8")
         json_data = json.loads(file_content)
@@ -1630,7 +1634,7 @@ def test_project_messages_export_json(self):
 
         self.assertIsInstance(response, FileResponse)
         self.assertEqual(response.get("Content-Type"), "application/json")
-        self.assertTrue(response.get("Content-Disposition").startswith("attachment"))
+        self.assertTrue(response.get("Content-Disposition").startswith("inline"))
 
         file_content = b"".join(response.streaming_content).decode("utf-8")
         json_data = json.loads(file_content)
@@ -1656,7 +1660,7 @@ def test_project_codebase_resources_export_json(self):
 
         self.assertIsInstance(response, FileResponse)
         self.assertEqual(response.get("Content-Type"), "application/json")
-        self.assertTrue(response.get("Content-Disposition").startswith("attachment"))
+        self.assertTrue(response.get("Content-Disposition").startswith("inline"))
 
         file_content = b"".join(response.streaming_content).decode("utf-8")
         json_data = json.loads(file_content)

scanpipe/views.py

@@ -540,11 +540,13 @@ def export_json_file_response(self):
         serializer = serializer_class(queryset, many=True)
         serialized_data = json.dumps(serializer.data, indent=2, cls=DjangoJSONEncoder)
 
-        output_file = io.BytesIO(serialized_data.encode("utf-8"))
+        encoded_data = serialized_data.encode("utf-8")
+        output_file = io.BytesIO(encoded_data)
+        is_too_large = len(encoded_data) > scanpipe_settings.INLINE_DOWNLOAD_MAX_SIZE
 
         return FileResponse(
             output_file,
-            as_attachment=True,
+            as_attachment=is_too_large,
             filename=self.get_export_json_filename(),
             content_type="application/json",
         )