Skip to content

Commit 0334beb

Browse files
committed
Fixed pycodestyle error and re-worded variable names
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
1 parent f1a1e99 commit 0334beb

2 files changed

Lines changed: 20 additions & 11 deletions

File tree

app/vulncode_app/data_dump.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,13 @@
2828
from vulncode_app.models import Package
2929
from vulncode_app.models import PackageReference
3030

31-
from scraper import debian
32-
from scraper import ubuntu
31+
from scraper import debian, ubuntu
3332

3433

35-
def data_debian_dump():
34+
def debian_data():
35+
"""
36+
Scrape debian' security tracker.
37+
"""
3638
json_data = debian.json_data()
3739
extract_data = debian.extract_data(json_data)
3840

@@ -52,15 +54,21 @@ def debian_dump(extract_data):
5254
vulnerability_reference.save()
5355
package.save()
5456

55-
return vulnerability, vulnerability_reference, package
57+
return vulnerability, vulnerability_reference, package
5658

5759

58-
def ubuntu_dump():
60+
def ubuntu_data():
5961
"""
60-
Dump data scraped from Ubuntu's security tracker.
62+
Scrape Ubuntu' main security tracker.
6163
"""
6264
data = ubuntu.scrape_cves()
65+
return data
66+
6367

68+
def ubuntu_dump():
69+
"""
70+
Dump data scraped from Ubuntu's security tracker.
71+
"""
6472
for data in extract_data:
6573
vulnerability_reference = VulnerabilityReference(reference_id=data.get('cve_id'))
6674
package = ImpactedPackage(name=data.get('package_name'))

app/vulncode_app/test_data_dump.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,10 @@ def test_data_dump(self):
4242
with open("tests/test_data/debian.json") as f:
4343
test_data = json.loads(f.read())
4444

45-
debian_extract_data = debian.extract_data(test_data)
46-
data_dump = debian_dump(debian_extract_data)
45+
extract_data = debian.extract_data(test_data)
46+
data_dump = debian_dump(extract_data)
4747

48-
self.assertEqual(data_dump[0].summary, None)
49-
self.assertEqual(data_dump[1].reference_id, "TEMP-0807341-84E914")
50-
self.assertEqual(data_dump[2].name, "git-repair")
48+
self.assertEqual(data_dump[0].summary, extract_data[0].get('description'))
49+
self.assertEqual(data_dump[1].reference_id, extract_data[0].get('vulnerability_id'))
50+
self.assertEqual(data_dump[2].name, extract_data[0].get('package_name'))
51+
self.assertEqual(data_dump[2].version, extract_data[0].get('fixed_version'))

0 commit comments

Comments
 (0)