Skip to content

Commit 0c9bf6f

Browse files
committed
Revert "Add FIXME comment to Etag function"
This reverts commit 38d4d1a.
1 parent dc21a60 commit 0c9bf6f

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

vulnerabilities/helpers.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import json
2424
import re
2525

26+
import yaml
2627
import requests
2728
import toml
28-
import yaml
2929

3030

3131
def load_yaml(path):
@@ -43,13 +43,6 @@ def load_toml(path):
4343
return toml.load(f)
4444

4545

46-
# FIXME: this is NOT how etags work .
47-
# We should instead send the proper HTTP header
48-
# https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-None-Match
49-
# and integrate this finely in the processing as this typically needs to use
50-
# streaming=True requests, and proper handling of the HTTP return code
51-
# In all cases this ends up being a single request, not a HEADD followed
52-
# by another real request
5346
def create_etag(data_src, url, etag_key):
5447
"""
5548
Etags are like hashes of web responses. For a data source `data_src`,

0 commit comments

Comments
 (0)