Skip to content

Commit 0ef58f2

Browse files
committed
Adress review comments
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 9be3549 commit 0ef58f2

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

vulnerabilities/import_runner.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from vulnerabilities.importer import AdvisoryData
2020
from vulnerabilities.importer import Importer
2121
from vulnerabilities.improver import Inference
22-
from vulnerabilities.improvers.default import AdvisoryBasedDefaultImprover
22+
from vulnerabilities.improvers.default import DefaultImporter
2323
from vulnerabilities.models import Advisory
2424
from vulnerabilities.models import Alias
2525
from vulnerabilities.models import Package
@@ -59,9 +59,9 @@ def run(self) -> None:
5959
logger.info(f"Finished import for {importer_name}. Imported {count} advisories.")
6060

6161
def do_import(self, advisories) -> None:
62-
advisory_importer = AdvisoryBasedDefaultImprover(advisories=advisories)
63-
logger.info(f"Running improver: {advisory_importer.qualified_name}")
64-
improver_name = advisory_importer.qualified_name
62+
advisory_importer = DefaultImporter(advisories=advisories)
63+
logger.info(f"Running importer: {advisory_importer.qualified_name}")
64+
importer_name = advisory_importer.qualified_name
6565
advisories = []
6666
for advisory in advisory_importer.interesting_advisories:
6767
if advisory.date_imported:
@@ -74,11 +74,11 @@ def do_import(self, advisories) -> None:
7474
process_inferences(
7575
inferences=inferences,
7676
advisory=advisory,
77-
improver_name=improver_name,
77+
improver_name=importer_name,
7878
)
7979
except Exception as e:
8080
logger.info(f"Failed to process advisory: {advisory!r} with error {e!r}")
81-
logger.info("Finished improving using %s.", advisory_importer.__class__.qualified_name)
81+
logger.info("Finished importing using %s.", advisory_importer.__class__.qualified_name)
8282

8383
def process_advisories(
8484
self, advisory_datas: Iterable[AdvisoryData], importer_name: str

vulnerabilities/improvers/default.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def get_exact_purls(affected_package: AffectedPackage) -> Tuple[List[PackageURL]
134134
return [], []
135135

136136

137-
class AdvisoryBasedDefaultImprover(DefaultImprover):
137+
class DefaultImporter(DefaultImprover):
138138
def __init__(self, advisories) -> None:
139139
self.advisories = advisories
140140

0 commit comments

Comments
 (0)