Skip to content

Commit 16479ea

Browse files
committed
Fix tests
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent f7b37be commit 16479ea

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

vulnerabilities/tests/pipelines/v2_improvers/test_enhance_with_github_poc.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ def test_github_poc_db_improver(mock_fetch_via_vcs):
4141
unique_content_id="sgsdg45",
4242
url="https://test.com",
4343
date_collected=datetime.now(),
44+
pipeline_id="ghsa_pipeline_v2",
4445
)
4546
adv2 = AdvisoryV2.objects.create(
4647
advisory_id="VCIO-123-1002",
@@ -49,6 +50,7 @@ def test_github_poc_db_improver(mock_fetch_via_vcs):
4950
unique_content_id="6hd4d6f",
5051
url="https://test.com",
5152
date_collected=datetime.now(),
53+
pipeline_id="ghsa_pipeline_v2",
5254
)
5355
adv3 = AdvisoryV2.objects.create(
5456
advisory_id="VCIO-123-1003",
@@ -57,6 +59,7 @@ def test_github_poc_db_improver(mock_fetch_via_vcs):
5759
unique_content_id="sd6h4sh",
5860
url="https://test.com",
5961
date_collected=datetime.now(),
62+
pipeline_id="ghsa_pipeline_v2",
6063
)
6164

6265
alias1 = AdvisoryAlias.objects.create(alias="CVE-2022-0236")

vulnerabilities/tests/pipelines/v2_improvers/test_reference_collect_commits_v2.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ def test_collect_fix_commits_pipeline_creates_entry():
2929
url="https://example.com/advisory/CVE-2025-1000",
3030
unique_content_id="11111",
3131
date_collected=datetime.now(),
32+
pipeline_id="test-pipeline",
3233
)
3334

3435
reference = AdvisoryReference.objects.create(
@@ -60,6 +61,7 @@ def test_collect_fix_commits_pipeline_skips_non_commit_urls():
6061
url="https://example.com/advisory/CVE-2025-2000",
6162
unique_content_id="11111",
6263
date_collected=datetime.now(),
64+
pipeline_id="test-pipeline",
6365
)
6466

6567
reference = AdvisoryReference.objects.create(

vulnerabilities/tests/test_api_v3.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def setUp(self):
3232
advisory_id="GHSA-1234",
3333
url="https://example.com/advisory",
3434
),
35-
pipeline_id="ghsa",
35+
pipeline_id="ghsa_pipeline_v2",
3636
datasource_id="ghsa",
3737
logger=self.logger.write,
3838
)
@@ -95,7 +95,8 @@ def test_advisories_post(self):
9595
self.assertEqual(response.status_code, status.HTTP_200_OK)
9696

9797
advisory = response.data["results"][0]
98-
self.assertEqual(advisory["advisory_id"], "ghsa/GHSA-1234")
98+
self.assertEqual(advisory["advisory_id"], "GHSA-1234")
99+
self.assertEqual(advisory["advisory_uid"], "ghsa/GHSA-1234")
99100

100101
def test_affected_by_advisories_list(self):
101102
url = reverse("affected-by-advisories-list")
@@ -110,7 +111,7 @@ def test_affected_by_advisories_list(self):
110111

111112
results = response.data["results"]
112113
self.assertEqual(len(results), 1)
113-
self.assertEqual(results[0]["advisory_id"], "ghsa/GHSA-1234")
114+
self.assertEqual(results[0]["advisory_id"], "GHSA-1234")
114115

115116
def test_fixing_advisories_list_empty(self):
116117
url = reverse("fixing-advisories-list")
@@ -198,7 +199,7 @@ def test_advisories_post(self):
198199
self.assertEqual(response.status_code, status.HTTP_200_OK)
199200
self.assertEqual(len(response.data["results"]), 100)
200201
advisory = response.data["results"][0]
201-
self.assertEqual(advisory["advisory_id"], "ghsa/GHSA-12341")
202+
self.assertEqual(advisory["advisory_id"], "GHSA-12341")
202203

203204

204205
class APIV3TestCaseOneAdvisoryMultiplePackages(APITestCase):

0 commit comments

Comments
 (0)