Merge pull request #476 from Hritik14/coding_style

Sort imports

Author: Hritik14

Makefile

@@ -27,6 +27,7 @@ VENV=venv
 ACTIVATE?=. ${VENV}/bin/activate;
 VIRTUALENV_PYZ=etc/thirdparty/virtualenv.pyz
 BLACK_ARGS=-l 100 .
+ISORT_ARGS=.
 # Do not depend on Python to generate the SECRET_KEY
 GET_SECRET_KEY=`base64 /dev/urandom | head -c50`
 # Customize with `$ make envfile ENV_FILE=/etc/vulnerablecode/.env`
@@ -61,14 +62,20 @@ envfile:
 	@echo SECRET_KEY=\"${GET_SECRET_KEY}\" > ${ENV_FILE}
 
 check:
+	@echo "-> Run isort validation"
+	@${ACTIVATE} isort --check-only ${ISORT_ARGS}
 	@echo "-> Run black validation"
 	@${ACTIVATE} black --check ${BLACK_ARGS}
 
 black:
 	@echo "-> Apply black code formatter"
 	${VENV}/bin/black ${BLACK_ARGS}
 
-valid: black
+isort:
+	@echo "-> Apply isort code formatter"
+	${VENV}/bin/isort ${ISORT_ARGS}
+
+valid: isort black
 
 clean:
 	@echo "-> Clean the Python env"

pyproject.toml

@@ -43,4 +43,10 @@ addopts = [
     "-rfExXw",
     "--strict",
     "--doctest-modules"
-]
+]
+
+[tool.isort]
+profile = "black"
+line_length = 100
+force_single_line = true
+skip_gitignore = true

requirements-dev.txt

@@ -1,5 +1,6 @@
-pytest
-pytest-django
-freezegun
-ipython
-black
+black==22.1.0
+freezegun==1.1.0
+ipython==8.0.1
+isort==5.10.1
+pytest==7.0.0
+pytest-django==4.5.2

setup.py

@@ -4,7 +4,6 @@
 from setuptools import find_packages
 from setuptools import setup
 
-
 requirements = [
     r.strip() for r in open("requirements.txt") if r.strip() and not r.strip().startswith("#")
 ]

vulnerabilities/admin.py

@@ -23,13 +23,11 @@
 
 from django.contrib import admin
 
-from vulnerabilities.models import (
-    PackageRelatedVulnerability,
-    Package,
-    Vulnerability,
-    VulnerabilityReference,
-    VulnerabilitySeverity,
-)
+from vulnerabilities.models import Package
+from vulnerabilities.models import PackageRelatedVulnerability
+from vulnerabilities.models import Vulnerability
+from vulnerabilities.models import VulnerabilityReference
+from vulnerabilities.models import VulnerabilitySeverity
 
 
 @admin.register(Vulnerability)

vulnerabilities/api.py

@@ -25,10 +25,11 @@
 
 from django_filters import rest_framework as filters
 from packageurl import PackageURL
-
-from rest_framework import serializers, viewsets
+from rest_framework import serializers
+from rest_framework import viewsets
 from rest_framework.decorators import action
 from rest_framework.response import Response
+
 from vulnerabilities.models import Package
 from vulnerabilities.models import Vulnerability
 from vulnerabilities.models import VulnerabilityReference

vulnerabilities/forms.py

@@ -22,7 +22,9 @@
 
 from django import forms
 
-from vulnerabilities.models import Package, PackageRelatedVulnerability, Vulnerability
+from vulnerabilities.models import Package
+from vulnerabilities.models import PackageRelatedVulnerability
+from vulnerabilities.models import Vulnerability
 
 
 def get_package_types():

vulnerabilities/import_runner.py

@@ -25,14 +25,13 @@
 import datetime
 import json
 import logging
-from typing import List
 from typing import Iterable
-
+from typing import List
 
 from vulnerabilities import models
-from vulnerabilities.models import Advisory
 from vulnerabilities.importer import AdvisoryData
 from vulnerabilities.importer import Importer
+from vulnerabilities.models import Advisory
 
 logger = logging.getLogger(__name__)
 

vulnerabilities/importer.py

@@ -20,19 +20,19 @@
 #  VulnerableCode is a free software code scanning tool from nexB Inc. and others.
 #  Visit https://github.com/nexB/vulnerablecode/ for support and download.
 import dataclasses
+import datetime
 import logging
 import os
 import shutil
 import tempfile
 import traceback
 import xml.etree.ElementTree as ET
-import datetime
 from pathlib import Path
+from typing import Iterable
 from typing import List
 from typing import Mapping
 from typing import Optional
 from typing import Set
-from typing import Iterable
 from typing import Tuple
 
 from binaryornot.helpers import is_binary_string
@@ -41,11 +41,12 @@
 from packageurl import PackageURL
 from univers.version_range import VersionRange
 from univers.versions import Version
-from vulnerabilities.helpers import nearest_patched_package
+
 from vulnerabilities.helpers import classproperty
+from vulnerabilities.helpers import nearest_patched_package
 from vulnerabilities.oval_parser import OvalParser
-from vulnerabilities.severity_systems import ScoringSystem
 from vulnerabilities.severity_systems import SCORING_SYSTEMS
+from vulnerabilities.severity_systems import ScoringSystem
 
 logger = logging.getLogger(__name__)
 

vulnerabilities/importers/alpine_linux.py

@@ -29,10 +29,10 @@
 import saneyaml
 from bs4 import BeautifulSoup
 
+from vulnerabilities.helpers import is_cve
 from vulnerabilities.importer import Advisory
 from vulnerabilities.importer import Importer
 from vulnerabilities.importer import Reference
-from vulnerabilities.helpers import is_cve
 
 BASE_URL = "https://secdb.alpinelinux.org/"