🐛 Avoid giving user the opportunity to create conflicting relations

Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>

Author: sbs2001

vulnerabilities/views.py

@@ -110,7 +110,7 @@ def _package_vulnerabilities(self, package_pk):
         return resolved_vuln, unresolved_vuln
 
     def get_success_url(self):
-        return reverse('package_view', kwargs={'pk': self.kwargs["pk"]})
+        return reverse("package_view", kwargs={"pk": self.kwargs["pk"]})
 
 
 class VulnerabilityDetails(ListView):
@@ -175,6 +175,13 @@ class PackageRelatedVulnerablityCreate(CreateView):
     model = models.PackageRelatedVulnerability
     fields = ["vulnerability"]
 
+    def get_form(self, *args, **kwargs):
+        form = super(PackageRelatedVulnerablityCreate, self).get_form(*args, **kwargs)
+        form.fields["vulnerability"].queryset = models.Vulnerability.objects.exclude(
+            package__pk=self.kwargs["pid"]
+        )
+        return form
+
     def form_valid(self, form):
 
         is_vulnerable = "impacted" in self.request.headers["Referer"]