Skip to content

Commit 423ef69

Browse files
committed
Remove made up alias
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent ee25f47 commit 423ef69

1 file changed

Lines changed: 10 additions & 17 deletions

File tree

  • vulnerabilities/importers

vulnerabilities/importers/npm.py

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -97,28 +97,21 @@ def to_advisory_data(self, file: Path) -> List[AdvisoryData]:
9797
affected_packages.append(self.get_affected_package(data, package_name))
9898
advsisory_aliases = data.get("cves") or []
9999

100-
# If an adviosry has more than one CVE, then we should yield more than one advisory
101-
if len(advsisory_aliases) > 1:
102-
print(f"Found {len(advsisory_aliases)} CVEs for {id}")
103-
for alias in advsisory_aliases:
104-
yield AdvisoryData(
105-
summary=build_description(summary=summary, description=description),
106-
references=references,
107-
date_published=date_published,
108-
affected_packages=affected_packages,
109-
aliases=[alias],
110-
)
111-
112-
# If an advisory has only one CVE, then we should yield only one advisory
113-
# with the NPM ID also as an alias
114-
else:
115-
advsisory_aliases.append(f"NPM-{id}")
100+
for alias in advsisory_aliases:
101+
yield AdvisoryData(
102+
summary=build_description(summary=summary, description=description),
103+
references=references,
104+
date_published=date_published,
105+
affected_packages=affected_packages,
106+
aliases=[alias],
107+
)
108+
109+
if not advsisory_aliases:
116110
yield AdvisoryData(
117111
summary=build_description(summary=summary, description=description),
118112
references=references,
119113
date_published=date_published,
120114
affected_packages=affected_packages,
121-
aliases=advsisory_aliases,
122115
)
123116

124117
def get_affected_package(self, data, package_name):

0 commit comments

Comments
 (0)