add tests for failing cases

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/importers/alpine_linux.py

@@ -20,6 +20,7 @@
 #  for any legal advice.
 #  VulnerableCode is a free software code scanning tool from nexB Inc. and others.
 #  Visit https://github.com/nexB/vulnerablecode/ for support and download.
+import logging
 from typing import Any
 from typing import Iterable
 from typing import List
@@ -38,6 +39,7 @@
 from vulnerabilities.references import XsaReference
 from vulnerabilities.references import ZbxReference
 
+LOGGER = logging.getLogger(__name__)
 BASE_URL = "https://secdb.alpinelinux.org/"
 
 
@@ -104,6 +106,8 @@ def process_record(record: dict) -> List[AdvisoryData]:
     Return a list of AdvisoryData objects by processing data
     present in that `record`
     """
+    if not record["packages"]:
+        raise Exception(f'"packages" not found in this {record!r}')
 
     advisories: List[AdvisoryData] = []
 
@@ -126,21 +130,18 @@ def load_advisories(
     pkg_infos: Mapping[str, Any],
     distroversion: str,
     reponame: str,
-    archs: Iterable[str],
+    archs: List[str],
 ) -> Iterable[AdvisoryData]:
     """
     Yields AdvisoryData by mapping data from `pkg_infos`
     and form PURL for AffectedPackages by using
     `distroversion`, `reponame`, `archs`
     """
-
-    if not pkg_infos.get("name"):
-        raise Exception('"name" is not available in package')
+    assert pkg_infos.get("name"), '"name" is not available in package'
 
     for version, fixed_vulns in pkg_infos["secfixes"].items():
 
-        if fixed_vulns is None:
-            raise Exception(f"No fixed vulnerabilities in {version}")
+        assert fixed_vulns, f"No fixed vulnerabilities in {version}"
 
         for vuln_ids in fixed_vulns:
             assert isinstance(vuln_ids, str)

vulnerabilities/tests/test_alpine.py

@@ -23,13 +23,15 @@
 import json
 import os
 
+import pytest
 from packageurl import PackageURL
 from univers.versions import AlpineLinuxVersion
 
 from vulnerabilities.importer import AdvisoryData
 from vulnerabilities.importer import AffectedPackage
 from vulnerabilities.importers.alpine_linux import fetch_advisory_directory_links
 from vulnerabilities.importers.alpine_linux import fetch_advisory_links
+from vulnerabilities.importers.alpine_linux import load_advisories
 from vulnerabilities.importers.alpine_linux import process_record
 from vulnerabilities.references import XsaReference
 
@@ -38,11 +40,6 @@
 
 
 def test_process_record():
-    # INVALID VERSIONS
-    # 1.9.5p2-r0
-    # 6.6.2p1-r0
-    # 6.6.4p1-r1
-    # 4.10-1-r1
     expected_advisories = [
         AdvisoryData(
             aliases=[],
@@ -483,7 +480,63 @@ def test_fetch_advisory_directory_links():
         assert fetch_advisory_directory_links(f.read()) == expected
 
 
+def test_fetch_advisory_directory_links_failure():
+    with open(os.path.join(TEST_DATA, "web_pages", "fail_directory.html")) as f:
+        with pytest.raises(Exception):
+            fetch_advisory_directory_links(f.read())
+
+
 def test_fetch_advisory_links():
     expected = ["v3.11community.json", "v3.11main.json"]
     with open(os.path.join(TEST_DATA, "web_pages", "v3.11.html")) as f:
         assert list(fetch_advisory_links(f.read(), "v3.11")) == expected
+
+
+def test_fetch_advisory_links_failure():
+    with open(os.path.join(TEST_DATA, "web_pages", "fail_directory.html")) as f:
+        with pytest.raises(Exception):
+            fetch_advisory_links(f.read())
+
+
+def test_process_record_without_packages():
+    with open(os.path.join(TEST_DATA, os.path.join(TEST_DATA, "v3.3", "community.json"))) as f:
+        with pytest.raises(Exception):
+            process_record(f.read())
+
+
+def test_load_advisories_package_without_name():
+    package = {
+        "secfixes": {"4.10.0-r1": ["XSA-248"], "4.10.0-r2": ["CVE-2018-7540 XSA-252"]},
+    }
+    with pytest.raises(Exception):
+        list(load_advisories(package, "v3.11", "main", archs=[]))
+
+
+def test_load_advisories_package_without_secfixes():
+    package = {
+        "name": "xen",
+        "secfixes": {"4.10.0-r1": []},
+    }
+    with pytest.raises(Exception):
+        list(load_advisories(package, "v3.11", "main", archs=[]))
+
+
+@pytest.mark.parametrize(
+    "test_case",
+    [
+        # these are the tests are not supported yet
+        # when we start supporting these version,
+        # they will be moved back to main test suite
+        "1.9.5p2-r0",
+        "6.6.2p1-r0",
+        "6.6.4p1-r1",
+        "4.10-1-r1",
+    ],
+)
+def test_load_advisories_package_with_invalid_alpine_version(test_case):
+    package = {
+        "name": "xen",
+        "secfixes": {f"{test_case}": ["XSA-248"]},
+    }
+    with pytest.raises(Exception):
+        list(load_advisories(package, "v3.11", "main", archs=[]))

vulnerabilities/tests/test_data/alpine/web_pages/fail_directory.html

@@ -0,0 +1,3 @@
+<html>
+    
+</html>