Make PR review changes for PR #290

* Correct typo in severity_systems.py

* Use typo for scoring fields instead of list
  in models.py

* Handle absence of bugzilla and RHSA  better in redhat.py

Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>

Author: sbs2001

vulnerabilities/importers/redhat.py

@@ -76,8 +76,8 @@ def to_advisory(advisory_data):
                 affected_purls.append(rpm_to_purl(rpm))
 
     references = []
-    if advisory_data.get("bugzilla"):
-        bugzilla = advisory_data.get("bugzilla")
+    bugzilla = advisory_data.get("bugzilla")
+    if bugzilla:
         url = "https://bugzilla.redhat.com/show_bug.cgi?id={}".format(bugzilla)
         bugzilla_data = requests.get(f"https://bugzilla.redhat.com/rest/bug/{bugzilla}").json()
         bugzilla_severity_val = bugzilla_data["bugs"][0]["severity"]
@@ -98,7 +98,7 @@ def to_advisory(advisory_data):
         # RH provides 3 types of advisories RHSA, RHBA, RHEA. Only RHSA's contain severity score.
         # See https://access.redhat.com/articles/2130961 for more details.
 
-        if "RHSA" in rh_adv:
+        if "RHSA" in rh_adv.upper():
             rhsa_data = requests.get(f"https://access.redhat.com/hydra/rest/securitydata/cvrf/{rh_adv}.json").json()  # nopep8
             value = rhsa_data["cvrfdoc"]["aggregate_severity"]
             rhsa_aggregate_severity = VulnerabilitySeverity(

vulnerabilities/models.py

@@ -204,7 +204,7 @@ def __str__(self):
 
 class VulnerabilitySeverity(models.Model):
 
-    scoring_system_choices = [(system.identifier, system.name) for system in scoring_systems.values()]  # nopep8
+    scoring_system_choices = ((system.identifier, system.name) for system in scoring_systems.values())  # nopep8
     vulnerability = models.ForeignKey(Vulnerability, on_delete=models.CASCADE)
     value = models.CharField(max_length=50, help_text="Example: 9.0, Important, High")
     scoring_system = models.CharField(

vulnerabilities/severity_systems.py

@@ -17,7 +17,7 @@ class ScoringSystem:
     def as_score(self, value):
         """
         Return a normalized numeric score for this scoring system  given a raw
-        value. For instance htis can be used to convert a CVSS vector to a base
+        value. For instance this can be used to convert a CVSS vector to a base
         score.
         """
         raise NotImplementedError