Skip to content

Commit 63ca14e

Browse files
committed
Add PyPI OSV importer
Reference: #607 Signed-off-by: Ziad <ziadhany2016@gmail.com> add the necessary changes Signed-off-by: Ziad <ziadhany2016@gmail.com> remove aliases de-duplicate Signed-off-by: Ziad <ziadhany2016@gmail.com> reslove conflicts Signed-off-by: Ziad <ziadhany2016@gmail.com> add dateparser to setup.cfg Signed-off-by: Ziad <ziadhany2016@gmail.com> Resolving conflicts Signed-off-by: Ziad <ziadhany2016@gmail.com> resolve conflicts Signed-off-by: Ziad <ziadhany2016@gmail.com> add a require changes Signed-off-by: Ziad <ziadhany2016@gmail.com> add a require changes Signed-off-by: Ziad <ziadhany2016@gmail.com> add a require changes Signed-off-by: Ziad <ziadhany2016@gmail.com>
1 parent 47f6ae6 commit 63ca14e

7 files changed

Lines changed: 1050 additions & 0 deletions

File tree

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,3 +113,4 @@ wcwidth==0.2.5
113113
websocket-client==0.59.0
114114
yarl==1.7.2
115115
zipp==3.8.0
116+
dateparser==1.1.1

setup.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ install_requires =
7575
lxml>=4.6.4
7676
defusedxml>=0.7.1
7777
Markdown>=3.3.0
78+
dateparser>=1.1.1
7879

7980
# networking
8081
GitPython>=3.1.17

vulnerabilities/helpers.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,3 +267,16 @@ def _get_gh_response(gh_token, graphql_query):
267267
endpoint = "https://api.github.com/graphql"
268268
headers = {"Authorization": f"bearer {gh_token}"}
269269
return requests.post(endpoint, headers=headers, json=graphql_query).json()
270+
271+
272+
def dedupe(original: List) -> List:
273+
"""
274+
Remove all duplicate items and return a new list preserving ordering
275+
>>> dedupe(["z","i","a","a","d","d"])
276+
['z', 'i', 'a', 'd']
277+
"""
278+
new_list = []
279+
for i in original:
280+
if i not in new_list:
281+
new_list.append(i)
282+
return new_list

vulnerabilities/importers/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,15 @@
2424
from vulnerabilities.importers import nginx
2525
from vulnerabilities.importers import nvd
2626
from vulnerabilities.importers import openssl
27+
from vulnerabilities.importers import pysec
2728

2829
IMPORTERS_REGISTRY = [
2930
nginx.NginxImporter,
3031
alpine_linux.AlpineImporter,
3132
github.GitHubAPIImporter,
3233
nvd.NVDImporter,
3334
openssl.OpensslImporter,
35+
pysec.PyPIImporter,
3436
]
3537

3638
IMPORTERS_REGISTRY = {x.qualified_name: x for x in IMPORTERS_REGISTRY}

vulnerabilities/importers/pysec.py

Lines changed: 256 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,256 @@
1+
# Copyright (c) 2017 nexB Inc. and others. All rights reserved.
2+
# http://nexb.com and https://github.com/nexB/vulnerablecode/
3+
# The VulnerableCode software is licensed under the Apache License version 2.0.
4+
# Data generated with VulnerableCode require an acknowledgment.
5+
#
6+
# You may not use this software except in compliance with the License.
7+
# You may obtain a copy of the License at: http://apache.org/licenses/LICENSE-2.0
8+
# Unless required by applicable law or agreed to in writing, software distributed
9+
# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
10+
# CONDITIONS OF ANY KIND, either express or implied. See the License for the
11+
# specific language governing permissions and limitations under the License.
12+
#
13+
# When you publish or redistribute any data created with VulnerableCode or any VulnerableCode
14+
# derivative work, you must accompany this data with the following acknowledgment:
15+
#
16+
# Generated with VulnerableCode and provided on an "AS IS" BASIS, WITHOUT WARRANTIES
17+
# OR CONDITIONS OF ANY KIND, either express or implied. No content created from
18+
# VulnerableCode should be considered or used as legal advice. Consult an Attorney
19+
# for any legal advice.
20+
# VulnerableCode is a free software code scanning tool from nexB Inc. and others.
21+
# Visit https://github.com/nexB/vulnerablecode/ for support and download.
22+
import json
23+
import logging
24+
from io import BytesIO
25+
from typing import Iterable
26+
from zipfile import ZipFile
27+
28+
import dateparser
29+
import requests
30+
from packageurl import PackageURL
31+
from univers.version_range import InvalidVersionRange
32+
from univers.version_range import PypiVersionRange
33+
from univers.versions import InvalidVersion
34+
from univers.versions import PypiVersion
35+
from univers.versions import SemverVersion
36+
37+
from vulnerabilities.helpers import dedupe
38+
from vulnerabilities.importer import AdvisoryData
39+
from vulnerabilities.importer import AffectedPackage
40+
from vulnerabilities.importer import Importer
41+
from vulnerabilities.importer import Reference
42+
from vulnerabilities.importer import VulnerabilitySeverity
43+
from vulnerabilities.severity_systems import SCORING_SYSTEMS
44+
45+
logger = logging.getLogger(__name__)
46+
47+
48+
class PyPIImporter(Importer):
49+
license_url = "https://github.com/pypa/advisory-database/blob/main/LICENSE"
50+
spdx_license_expression = "CC-BY-4.0"
51+
52+
def advisory_data(self) -> Iterable[AdvisoryData]:
53+
"""
54+
1. Fetch the data from osv api
55+
2. unzip the file
56+
3. open the file one by one
57+
4. yield the json file to parse_advisory_data
58+
"""
59+
url = "https://osv-vulnerabilities.storage.googleapis.com/PyPI/all.zip"
60+
response = requests.get(url).content
61+
with ZipFile(BytesIO(response)) as zip_file:
62+
for file_name in zip_file.namelist():
63+
if not file_name.startswith("PYSEC-"):
64+
logger.error(f"NotImplementedError PyPI package file_name: {file_name}")
65+
else:
66+
with zip_file.open(file_name) as f:
67+
vul_info = json.loads(f.read())
68+
yield parse_advisory_data(vul_info)
69+
70+
71+
def parse_advisory_data(raw_data: dict) -> AdvisoryData:
72+
summary = raw_data.get("summary") or ""
73+
aliases = get_aliases(raw_data)
74+
date_published = get_published_date(raw_data)
75+
severity = get_severity(raw_data)
76+
references = get_references(raw_data, severity)
77+
78+
affected_packages = []
79+
if "affected" not in raw_data:
80+
logger.error(f"affected_packages not found - {raw_data['id'] !r}")
81+
82+
if "affected" in raw_data:
83+
for affected_pkg in raw_data["affected"]:
84+
purl = get_affected_purl(affected_pkg, raw_data["id"])
85+
if purl.type != "pypi":
86+
logger.error(
87+
f"Non PyPI package found in PYSEC advisories: {purl} - from: {raw_data['id']!r}"
88+
)
89+
else:
90+
vulnid = raw_data["id"]
91+
affected_version_range = get_affected_version_range(affected_pkg, vulnid)
92+
for fixed_range in affected_pkg.get("ranges", []):
93+
fixed_version = get_fixed_version(fixed_range, vulnid)
94+
95+
for version in fixed_version:
96+
affected_packages.append(
97+
AffectedPackage(
98+
package=purl,
99+
affected_version_range=affected_version_range,
100+
fixed_version=version,
101+
)
102+
)
103+
104+
return AdvisoryData(
105+
aliases=aliases,
106+
summary=summary,
107+
affected_packages=affected_packages,
108+
references=references,
109+
date_published=date_published,
110+
)
111+
112+
113+
def fixed_filter(fixed_range) -> []:
114+
"""
115+
Return a list of fixed version strings given a ``fixed_range`` mapping of OSV data.
116+
>>> fixed_filter({"type": "SEMVER", "events": [{"introduced": "0"}, {"fixed": "1.6.0"}]})
117+
['1.6.0']
118+
>>> fixed_filter({"type": "ECOSYSTEM","events":[{"introduced": "0"},{"fixed": "1.0.0"},{"fixed": "9.0.0"}]})
119+
['1.0.0', '9.0.0']
120+
"""
121+
list_fixed = []
122+
for event in fixed_range.get("events") or []:
123+
fixed = event.get("fixed")
124+
if fixed:
125+
list_fixed.append(fixed)
126+
return list_fixed
127+
128+
129+
def get_aliases(raw_data) -> []:
130+
"""
131+
aliases field is optional , id is required and these are all aliases from our perspective
132+
converting list of two fields to a dict then , convert it to a list to make sure a list is unique
133+
>>> get_aliases({"id": "GHSA-j3f7-7rmc-6wqj"})
134+
['GHSA-j3f7-7rmc-6wqj']
135+
>>> get_aliases({"aliases": ["CVE-2021-40831"]})
136+
['CVE-2021-40831']
137+
>>> get_aliases({"aliases": ["CVE-2022-22817", "GHSA-8vj2-vxx3-667w"], "id": "GHSA-j3f7-7rmc-6wqj"})
138+
['CVE-2022-22817', 'GHSA-8vj2-vxx3-667w', 'GHSA-j3f7-7rmc-6wqj']
139+
"""
140+
vulnerability_id = raw_data.get("id")
141+
vulnerability_aliases = raw_data.get("aliases") or []
142+
if vulnerability_id:
143+
vulnerability_aliases.append(vulnerability_id)
144+
return vulnerability_aliases
145+
146+
147+
def get_published_date(raw_data):
148+
published = raw_data.get("published")
149+
return published and dateparser.parse(published)
150+
151+
152+
def get_severity(raw_data) -> []:
153+
severities = []
154+
if "severity" in raw_data:
155+
for sever_list in raw_data.get("severity") or []:
156+
if sever_list.get("type") == "CVSS_V3":
157+
severities.append(
158+
VulnerabilitySeverity(
159+
system=SCORING_SYSTEMS["cvssv3.1_vector"],
160+
value=sever_list["score"],
161+
)
162+
)
163+
else:
164+
logger.error(f"NotImplementedError severity type- {raw_data['id']!r}")
165+
166+
ecosys = raw_data.get("ecosystem_specific") or {}
167+
sever = ecosys.get("severity")
168+
if sever:
169+
severities.append(
170+
VulnerabilitySeverity(
171+
system=SCORING_SYSTEMS["generic_textual"],
172+
value=sever,
173+
)
174+
)
175+
176+
database_specific = raw_data.get("database_specific") or {}
177+
sever = database_specific.get("severity")
178+
if sever:
179+
severities.append(
180+
VulnerabilitySeverity(
181+
system=SCORING_SYSTEMS["generic_textual"],
182+
value=sever,
183+
)
184+
)
185+
186+
if not severities:
187+
logger.warning(f"severity not found- {raw_data['id']!r}")
188+
return []
189+
else:
190+
return severities
191+
192+
193+
def get_references(raw_data, severities) -> []:
194+
references = raw_data.get("references") or []
195+
return [Reference(url=ref["url"], severities=severities) for ref in references if ref]
196+
197+
198+
def get_affected_purl(affected_pkg, raw_id):
199+
package = affected_pkg.get("package") or {}
200+
purl = package.get("purl")
201+
if purl:
202+
try:
203+
return PackageURL.from_string(purl)
204+
except ValueError:
205+
logger.error(f"PackageURL ValueError - {raw_id !r} - purl: {purl !r}")
206+
207+
ecosys = package.get("ecosystem")
208+
name = package.get("name")
209+
if ecosys and name:
210+
return PackageURL(type=ecosys, name=name)
211+
else:
212+
logger.error(f"purl affected_pkg not found - {raw_id !r}")
213+
214+
215+
def get_affected_version_range(affected_pkg, raw_id):
216+
affected_versions = affected_pkg.get("versions")
217+
if affected_versions:
218+
try:
219+
return PypiVersionRange(affected_versions)
220+
except InvalidVersionRange:
221+
logger.error(f"InvalidVersionRange affected_pkg_version_range Error - {raw_id !r} ")
222+
else:
223+
logger.error(f"affected_pkg_version_range not found - {raw_id !r} ")
224+
225+
226+
def get_fixed_version(fixed_range, raw_id) -> []:
227+
"""
228+
Return a list of fixed versions, using fixed_filter we get the list of fixed version strings,
229+
then we pass every element to their univers.versions , then we dedupe the result
230+
>>> get_fixed_version({}, "GHSA-j3f7-7rmc-6wqj")
231+
[]
232+
>>> get_fixed_version({"type": "ECOSYSTEM", "events": [{"fixed": "1.7.0"}]}, "GHSA-j3f7-7rmc-6wqj")
233+
[PypiVersion(string='1.7.0')]
234+
"""
235+
fixed_version = []
236+
if "type" not in fixed_range:
237+
logger.error(f"Invalid type - {raw_id!r}")
238+
else:
239+
list_fixed = fixed_filter(fixed_range)
240+
fixed_range_type = fixed_range["type"]
241+
for i in list_fixed:
242+
if fixed_range_type == "ECOSYSTEM":
243+
try:
244+
fixed_version.append(PypiVersion(i))
245+
except InvalidVersion:
246+
logger.error(f"Invalid Version - PypiVersion - {raw_id !r} - {i !r}")
247+
if fixed_range_type == "SEMVER":
248+
try:
249+
fixed_version.append(SemverVersion(i))
250+
except InvalidVersion:
251+
logger.error(f"Invalid Version - SemverVersion - {raw_id !r} - {i !r}")
252+
if fixed_range_type == "GIT":
253+
# TODO add GitHubVersion univers fix_version
254+
logger.error(f"NotImplementedError GIT Version - {raw_id !r} - {i !r}")
255+
256+
return dedupe(fixed_version)

0 commit comments

Comments
 (0)