Skip to content

Commit 6a786b5

Browse files
committed
Preserve query in package search and improve views
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
1 parent a70404c commit 6a786b5

3 files changed

Lines changed: 19 additions & 29 deletions

File tree

vulnerabilities/templates/packages.html

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,16 @@ <h1 class="title">
2121
</button>
2222
</div>
2323
</form>
24+
{% if result_size %}
25+
<p class="has-text-centered" id="result_count">{{result_size}} results</p>
26+
{% elif result_size == 0 %}
27+
<p class="has-text-centered" id="result_count">No results found</p>
28+
{% endif %}
2429
</div>
2530
</div>
2631

2732
{% if packages %}
2833

29-
<section class="section is-small has-text-centered">
30-
<div class="container">
31-
<h1 class="title">Results of your query</h1>
32-
<h3 class="subtitle">Total Results {{ total_results }}</h3>
33-
</div>
34-
</section>
35-
3634
<section class="section">
3735
<div class="content is-medium">
3836
<table class="table is-bordered is-striped is-narrow is-hoverable is-fullwidth">

vulnerabilities/templates/vulnerabilities.html

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,21 @@ <h1 class="title">
88

99
<div class="columns">
1010
<div class="column is-one-third is-offset-one-third">
11-
<form action="{% url 'vulnerability_search' %}" method="get">
11+
<form action="{% url 'vulnerability_search' %}" method="get">
1212
{% load widget_tweaks %}
1313
<div class="field is-horizontal">
14-
{% with searched_for as query%}
15-
{% render_field form.vuln_id class="input" value=query %}
16-
{% endwith %}
14+
{% render_field form.vuln_id class="input"%}
1715
<button class="button is-success", type="submit">
1816
Search
1917
</button>
2018
</div>
21-
</form>
22-
{% if searched_for %}
23-
<p class="has-text-centered">{{result_size}} results</p>
24-
{% endif %}
25-
</div>
19+
</form>
20+
{% if result_size %}
21+
<p class="has-text-centered" id="result_count">{{result_size}} results</p>
22+
{% elif result_size == 0 %}
23+
<p class="has-text-centered" id="result_count">No results found</p>
24+
{% endif %}
25+
</div>
2626
</div>
2727

2828
{% if vulnerabilities %}
@@ -57,13 +57,6 @@ <h1 class="title">
5757

5858
</section>
5959

60-
{% elif result_size == 0 %}
61-
<section class="section is-medium has-text-centered">
62-
<div class="container">
63-
<h1 class="title" id="results">No result found for "{{searched_for}}"</h1>
64-
</div>
65-
</section>
66-
6760
{% endif %}
6861

69-
{% endblock %}
62+
{% endblock %}

vulnerabilities/views.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@ def get(self, request):
4646

4747
if request.GET:
4848
packages = self.request_to_queryset(request)
49-
total_results = packages.count()
49+
result_size = packages.count()
5050
page_no = int(request.GET.get("page", 1))
5151
packages = Paginator(packages, 50).get_page(page_no)
5252
context["packages"] = packages
5353
context["searched_for"] = urlencode(
5454
{param: request.GET[param] for param in request.GET if param != "page"}
5555
)
56-
context["total_results"] = total_results
56+
context["result_size"] = result_size
5757

5858
return render(request, self.template_name, context)
5959

@@ -74,14 +74,13 @@ class VulnerabilitySearchView(View):
7474
template_name = "vulnerabilities.html"
7575

7676
def get(self, request):
77-
context = {"form": forms.CVEForm()}
77+
context = {"form": forms.CVEForm(request.GET or None)}
7878
if request.GET:
7979
vulnerabilities = self.request_to_queryset(request)
80+
result_size = vulnerabilities.count()
8081
pages = Paginator(vulnerabilities, 50)
81-
result_size = pages.count
8282
vulnerabilities = pages.get_page(int(self.request.GET.get("page", 1)))
8383
context["vulnerabilities"] = vulnerabilities
84-
context["searched_for"] = request.GET.get("vuln_id")
8584
context["result_size"] = result_size
8685

8786
return render(request, self.template_name, context)

0 commit comments

Comments
 (0)