Skip to content

Commit 6f6f0c9

Browse files
committed
replace f string with urljoin
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 764f9bc commit 6f6f0c9

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

vulnerabilities/importers/alpine_linux.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def fetch_advisory_links(
111111
return iter([])
112112
for anchor_tag in anchor_tags:
113113
if anchor_tag.text.endswith("json"):
114-
yield f"{advisory_directory_link}{anchor_tag.text}"
114+
yield urljoin(advisory_directory_link, anchor_tag.text)
115115

116116

117117
def check_for_attributes(record) -> bool:

vulnerabilities/tests/test_alpine.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,9 +491,14 @@ def test_fetch_advisory_directory_links_failure(caplog):
491491

492492

493493
def test_fetch_advisory_links():
494-
expected = ["v3.11community.json", "v3.11main.json"]
494+
expected = [
495+
"https://secdb.alpinelinux.org/v3.11/community.json",
496+
"https://secdb.alpinelinux.org/v3.11/main.json",
497+
]
495498
with open(os.path.join(TEST_DATA, "web_pages", "v3.11.html")) as f:
496-
assert list(fetch_advisory_links(f.read(), "v3.11")) == expected
499+
assert (
500+
list(fetch_advisory_links(f.read(), "https://secdb.alpinelinux.org/v3.11/")) == expected
501+
)
497502

498503

499504
def test_fetch_advisory_links_failure(caplog):

0 commit comments

Comments
 (0)