Speed up test_upstream

Earlier, one batch of advisories was requested from updated_advisories
method of the respective importers. This was inefficient as not all
importers respect batching internally. Eventually, we wish to eliminate
batches as well ( # 338 ).
Now, the updated_advisories method of each importer is expected to
create at least one Advisory object. If it does so, the importer is
marked working.
This brings major performance improvement. It is a necessity to improve
this test as GitHub only allows 6 hrs of workflow time.
Before: ~6hrs, now ~9 minutes

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>

Author: Hritik14

vulnerabilities/tests/test_upstream.py

@@ -1,51 +1,54 @@
-import pytest
+import inspect
 from unittest.mock import patch
-from inspect import getmodule
-from inspect import getmro
+
+import pytest
 
 from vulnerabilities import importers
-from vulnerabilities.importer_yielder import IMPORTER_REGISTRY
 from vulnerabilities.data_source import Advisory
+from vulnerabilities.importer_yielder import IMPORTER_REGISTRY
+
+MAX_ADVISORIES = 1
 
-MAX_ADVISORIES = 2000
 
-class MaxAdvisoriesCreatedInterrupt(Exception):
+class MaxAdvisoriesCreatedInterrupt(BaseException):
+    # Inheriting BaseException is intentional because the function being tested might catch Exception
     pass
 
 
 @pytest.mark.webtest
 @pytest.mark.parametrize(
     ("data_source", "config"),
-    ((data["data_source"], data["data_source_cfg"]) for data in IMPORTER_REGISTRY[0:1]),
+    ((data["data_source"], data["data_source_cfg"]) for data in IMPORTER_REGISTRY),
 )
 def test_updated_advisories(data_source, config):
     if not data_source == "GitHubAPIDataSource":
         data_src = getattr(importers, data_source)
         data_src = data_src(batch_size=MAX_ADVISORIES, config=config)
-        module = getmodule(data_src).__name__
         advisory_counter = 0
 
-        def patched_advisory(**kwargs):
+        def patched_advisory(*args, **kwargs):
             nonlocal advisory_counter
-            ueatnhasnuth
-            advisory_counter += 1
 
             if advisory_counter >= MAX_ADVISORIES:
                 raise MaxAdvisoriesCreatedInterrupt
 
-            x =  Advisory(**kwargs)
-            with open("/tmp/x") as f:
-                f.write(x)
-            return x
-
-        with patch(f"{module}.Advisory", side_effect=patched_advisory, create=True):
+            advisory_counter += 1
+            return Advisory(*args, **kwargs)
+
+        module = inspect.getmodule(data_src)
+        module_members = [m[0] for m in inspect.getmembers(module)]
+        advisory_class = f"{module.__name__}.Advisory"
+        if "Advisory" not in module_members:
+            advisory_class = "vulnerabilities.data_source.Advisory"
+
+        # Either
+        # 1) Advisory class is successfully patched and MaxAdvisoriesCreatedInterrupt is thrown when
+        # 	an importer tries to create an Advisory or
+        # 2) Importer somehow bypasses the patch / handles BaseException internally, then
+        # 	updated_advisories is required to return non zero advisories
+        with patch(advisory_class, side_effect=patched_advisory):
             try:
                 with data_src:
-                    print(list(data_src.updated_advisories()))
-                    for i in data_src.updated_advisories():
-                        print("EE:")
-                        print(i)
+                    assert len(list(data_src.updated_advisories())) > 0
             except MaxAdvisoriesCreatedInterrupt:
                 pass
-
-