Reference: #729

Fix severity model

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/improve_runner.py

@@ -72,7 +72,6 @@ def process_inferences(inferences: List[Inference], advisory: Advisory, improver
 
             for severity in ref.severities:
                 _vs, updated = models.VulnerabilitySeverity.objects.update_or_create(
-                    vulnerability=vuln,
                     scoring_system=severity.system.identifier,
                     reference=reference,
                     defaults={"value": str(severity.value)},

vulnerabilities/migrations/0014_remove_duplicate_severities.py

@@ -0,0 +1,64 @@
+# Copyright (c)  nexB Inc. and others. All rights reserved.
+# http://nexb.com and https://github.com/nexB/vulnerablecode/
+# The VulnerableCode software is licensed under the Apache License version 2.0.
+# Data generated with VulnerableCode require an acknowledgment.
+#
+# You may not use this software except in compliance with the License.
+# You may obtain a copy of the License at: http://apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+#
+# When you publish or redistribute any data created with VulnerableCode or any VulnerableCode
+# derivative work, you must accompany this data with the following acknowledgment:
+#
+#  Generated with VulnerableCode and provided on an 'AS IS' BASIS, WITHOUT WARRANTIES
+#  OR CONDITIONS OF ANY KIND, either express or implied. No content created from
+#  VulnerableCode should be considered or used as legal advice. Consult an Attorney
+#  for any legal advice.
+#  VulnerableCode is a free software code scanning tool from nexB Inc. and others.
+#  Visit https://github.com/nexB/vulnerablecode/ for support and download.
+
+from django.db import migrations
+from django.db.models import Count
+from django.db.models import Max
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("vulnerabilities", "0013_auto_20220503_0941"),
+    ]
+
+    def remove_duplicate_rows(apps, schema_editor):
+        """
+        Find all duplicate rows and remove all of them except the latest one.
+        """
+        unique_fields = [
+            "reference",
+            "scoring_system",
+            "value",
+        ]
+        Severities = apps.get_model("vulnerabilities", "VulnerabilitySeverity")
+        # Get all duplicates according to the unique_fields
+        duplicates = (
+            Severities.objects.values(*unique_fields)
+            .order_by()
+            .annotate(max_id=Max("id"), count_id=Count("id"))
+            .filter(count_id__gt=1)
+        )
+        for duplicate in duplicates:
+            unique_fields_data = {
+                uniqe_field: duplicate[uniqe_field] for uniqe_field in unique_fields
+            }
+            # Get all rows with the same unique_fields_data
+            # exclude the latest one
+            # and delete rest of them
+            (
+                Severities.objects.filter(**unique_fields_data)
+                .exclude(id=duplicate["max_id"])
+                .delete()
+            )
+
+    operations = [migrations.RunPython(remove_duplicate_rows)]

vulnerabilities/migrations/0015_alter_vulnerabilityseverity_unique_together_and_more.py

@@ -0,0 +1,21 @@
+# Generated by Django 4.0.4 on 2022-05-16 15:07
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('vulnerabilities', '0014_remove_duplicate_severities'),
+    ]
+
+    operations = [
+        migrations.AlterUniqueTogether(
+            name='vulnerabilityseverity',
+            unique_together={('reference', 'scoring_system', 'value')},
+        ),
+        migrations.RemoveField(
+            model_name='vulnerabilityseverity',
+            name='vulnerability',
+        ),
+    ]

vulnerabilities/models.py

@@ -300,7 +300,6 @@ def update_or_create(self):
 
 class VulnerabilitySeverity(models.Model):
 
-    vulnerability = models.ForeignKey(Vulnerability, on_delete=models.CASCADE)
     reference = models.ForeignKey(VulnerabilityReference, on_delete=models.CASCADE)
 
     scoring_system_choices = tuple(
@@ -322,7 +321,6 @@ class VulnerabilitySeverity(models.Model):
 
     class Meta:
         unique_together = (
-            "vulnerability",
             "reference",
             "scoring_system",
             "value",