Skip to content

Commit a9172e4

Browse files
committed
fix optional parameter error
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 7233a37 commit a9172e4

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

vulnerabilities/importer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class AffectedPackage:
122122
"""
123123

124124
package: PackageURL
125-
affected_version_range: Optional[VersionRange]
125+
affected_version_range: Optional[VersionRange] = None
126126
fixed_version: Optional[Version] = None
127127

128128
def __post_init__(self):

vulnerabilities/importers/alpine_linux.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import requests
3030
from bs4 import BeautifulSoup
3131
from packageurl import PackageURL
32-
from univers.versions import AlpineLinuxVersion
32+
from univers.versions import AlpineLinuxsVersion
3333

3434
from vulnerabilities.helpers import is_cve
3535
from vulnerabilities.importer import AdvisoryData
@@ -46,6 +46,7 @@ def advisory_data(self) -> Iterable[AdvisoryData]:
4646
advisory_links = fetch_advisory_links()
4747
for link in advisory_links:
4848
advisories.extend(process_link(link))
49+
return advisories
4950

5051

5152
def fetch_advisory_links():
@@ -80,9 +81,6 @@ def process_link(link) -> List[AdvisoryData]:
8081
return advisories
8182

8283
for package in record["packages"]:
83-
assert isinstance(record.get("archs"), Iterable[str])
84-
assert isinstance(record.get("reponame"), str)
85-
assert isinstance(record.get("distroversion"), str)
8684
advisories.extend(
8785
load_advisories(
8886
package["pkg"],
@@ -101,11 +99,9 @@ def load_advisories(
10199
archs: Iterable[str],
102100
) -> Iterable[AdvisoryData]:
103101

104-
if not (pkg_infos.get("name") and isinstance(pkg_infos["name"], str)):
102+
if not pkg_infos.get("name"):
105103
return []
106104

107-
assert isinstance(pkg_infos["secfixes"], Mapping[str, List])
108-
109105
for version, fixed_vulns in pkg_infos["secfixes"].items():
110106

111107
if fixed_vulns is None:

0 commit comments

Comments
 (0)