Skip to content

Commit c5deeb1

Browse files
committed
Remove improvers for alpine and nvd
Add tests for default improver using alpine and nvd advisories. Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 8a12c7e commit c5deeb1

4 files changed

Lines changed: 345 additions & 31 deletions

File tree

vulnerabilities/importers/alpine_linux.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -245,21 +245,3 @@ def load_advisories(
245245
affected_packages=affected_packages,
246246
aliases=aliases,
247247
)
248-
249-
250-
class AlpineBasicImprover(Improver):
251-
@property
252-
def interesting_advisories(self) -> QuerySet:
253-
return Advisory.objects.filter(created_by=AlpineImporter.qualified_name)
254-
255-
def get_inferences(self, advisory_data: AdvisoryData) -> Iterable[Inference]:
256-
"""
257-
Generate and return Inferences for the given advisory data
258-
"""
259-
for affected_package in advisory_data.affected_packages:
260-
fixed_purl = affected_package.get_fixed_purl()
261-
yield Inference.from_advisory_data(
262-
advisory_data,
263-
confidence=MAX_CONFIDENCE,
264-
fixed_purl=fixed_purl,
265-
)

vulnerabilities/importers/nvd.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -195,14 +195,3 @@ def extract_severity_scores(cve_item):
195195
system=SCORING_SYSTEMS["cvssv2_vector"],
196196
value=str(cvss_v2.get("vectorString") or ""),
197197
)
198-
199-
200-
class NVDBasicImprover(Improver):
201-
@property
202-
def interesting_advisories(self) -> QuerySet:
203-
return Advisory.objects.filter(created_by=NVDImporter.qualified_name)
204-
205-
def get_inferences(self, advisory_data: AdvisoryData) -> Iterable[Inference]:
206-
yield Inference.from_advisory_data(
207-
advisory_data=advisory_data, confidence=100, fixed_purl=None
208-
)

vulnerabilities/improvers/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
IMPROVERS_REGISTRY = [
55
default.DefaultImprover,
66
importers.nginx.NginxBasicImprover,
7-
importers.alpine_linux.AlpineBasicImprover,
87
importers.github.GitHubBasicImprover,
9-
importers.nvd.NVDBasicImprover,
108
]
119

1210
IMPROVERS_REGISTRY = {x.qualified_name: x for x in IMPROVERS_REGISTRY}

0 commit comments

Comments
 (0)