Skip to content

Commit d18e03e

Browse files
committed
Implement added_advisories() method
As all the files in istio git repo are added and not updated, it is mandatory to handle `self._added_files` properly which was ignored earlier. This fixes #394 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
1 parent bfa005e commit d18e03e

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

vulnerabilities/importers/istio.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
from vulnerabilities.data_source import Advisory, GitDataSource, Reference
3232
from vulnerabilities.package_managers import GitHubTagsAPI
3333

34+
IS_RELEASE = re.compile(r"^[\d.]+$", re.IGNORECASE).match
3435

3536
class IstioDataSource(GitDataSource):
3637
def __enter__(self):
@@ -46,8 +47,13 @@ def __enter__(self):
4647
def set_api(self):
4748
asyncio.run(self.version_api.load_api(["istio/istio"]))
4849

50+
def added_advisories(self) -> Set[Advisory]:
51+
return self._load_advisories(self._added_files)
52+
4953
def updated_advisories(self) -> Set[Advisory]:
50-
files = self._updated_files
54+
return self._load_advisories(self._updated_files)
55+
56+
def _load_advisories(self, files) -> Set[Advisory]:
5157
advisories = []
5258
for f in files:
5359
processed_data = self.process_file(f)
@@ -131,7 +137,7 @@ def process_file(self, path):
131137
ubound = "<=" + release[2]
132138
releases.append(lbound + "," + ubound)
133139
# If it is a single release
134-
elif is_release(release):
140+
elif IS_RELEASE(release):
135141
releases.append(release)
136142

137143
data["release_ranges"] = releases
@@ -195,5 +201,3 @@ def get_data_from_md(self, path):
195201
with open(path) as f:
196202
yaml_lines = self.get_yaml_lines(f)
197203
return self.get_data_from_yaml_lines(yaml_lines)
198-
199-
is_release = re.compile(r"^[\d.]+$", re.IGNORECASE).match

0 commit comments

Comments
 (0)