Fix tests

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/importer.py

@@ -252,7 +252,8 @@ class AdvisoryData:
     def __post_init__(self):
         if self.date_published and not self.date_published.tzinfo:
             logger.warning(f"AdvisoryData with no tzinfo: {self!r}")
-        self.summary = self.clean_summary(self.summary)
+        if self.summary:
+            self.summary = self.clean_summary(self.summary)
 
     def clean_summary(self, summary):
         # https://nvd.nist.gov/vuln/detail/CVE-2013-4314

vulnerabilities/tests/test_data/elixir_security/elixir-expected.json

@@ -3,7 +3,7 @@
     "aliases": [
       "CVE-2018-20301"
     ],
-    "summary": "The Coherence library has \"Mass Assignment\"-like vulnerabilities.\n",
+    "summary": "The Coherence library has \"Mass Assignment\"-like vulnerabilities.",
     "affected_packages": [
       {
         "package": {

vulnerabilities/tests/test_data/elixir_security/elixir-improver-expected.json

@@ -5,7 +5,7 @@
       "CVE-2018-20301"
     ],
     "confidence": 100,
-    "summary": "The Coherence library has \"Mass Assignment\"-like vulnerabilities.\n",
+    "summary": "The Coherence library has \"Mass Assignment\"-like vulnerabilities.",
     "affected_purls": [
       {
         "type": "hex",
@@ -39,7 +39,7 @@
       "CVE-2018-20301"
     ],
     "confidence": 100,
-    "summary": "The Coherence library has \"Mass Assignment\"-like vulnerabilities.\n",
+    "summary": "The Coherence library has \"Mass Assignment\"-like vulnerabilities.",
     "affected_purls": [],
     "fixed_purl": null,
     "references": [

vulnerabilities/tests/test_data/gentoo/gentoo-expected.json

@@ -3,7 +3,7 @@
     "aliases": [
       "CVE-2017-9800"
     ],
-    "summary": "A command injection vulnerability in Subversion may allow remote\n    attackers to execute arbitrary code.\n  ",
+    "summary": "A command injection vulnerability in Subversion may allow remote\n    attackers to execute arbitrary code.",
     "affected_packages": [
       {
         "package": {

vulnerabilities/tests/test_data/github_api/npm-expected.json

@@ -345,7 +345,6 @@
     ],
     "date_published": "2022-11-28T22:06:24+00:00",
     "weaknesses": []
-
   },
   {
     "aliases": [
@@ -584,7 +583,7 @@
       "CVE-2022-41940",
       "GHSA-r7qp-cfhv-p84w"
     ],
-    "summary": "Uncaught exception in engine.io ",
+    "summary": "Uncaught exception in engine.io",
     "affected_packages": [
       {
         "package": {
@@ -646,7 +645,7 @@
       "CVE-2022-41940",
       "GHSA-r7qp-cfhv-p84w"
     ],
-    "summary": "Uncaught exception in engine.io ",
+    "summary": "Uncaught exception in engine.io",
     "affected_packages": [
       {
         "package": {
@@ -708,7 +707,7 @@
       "CVE-2022-41919",
       "GHSA-3fjj-p79j-c9hh"
     ],
-    "summary": "Fastify: Incorrect Content-Type parsing can lead to CSRF attack ",
+    "summary": "Fastify: Incorrect Content-Type parsing can lead to CSRF attack",
     "affected_packages": [
       {
         "package": {
@@ -770,7 +769,7 @@
       "CVE-2022-41919",
       "GHSA-3fjj-p79j-c9hh"
     ],
-    "summary": "Fastify: Incorrect Content-Type parsing can lead to CSRF attack ",
+    "summary": "Fastify: Incorrect Content-Type parsing can lead to CSRF attack",
     "affected_packages": [
       {
         "package": {
@@ -1451,7 +1450,7 @@
     "aliases": [
       "GHSA-3qmc-2r76-4rqp"
     ],
-    "summary": "Redwood is vulnerable to account takeover via dbAuth \"forgot-password\" ",
+    "summary": "Redwood is vulnerable to account takeover via dbAuth \"forgot-password\"",
     "affected_packages": [
       {
         "package": {
@@ -1517,7 +1516,7 @@
     "aliases": [
       "GHSA-3qmc-2r76-4rqp"
     ],
-    "summary": "Redwood is vulnerable to account takeover via dbAuth \"forgot-password\" ",
+    "summary": "Redwood is vulnerable to account takeover via dbAuth \"forgot-password\"",
     "affected_packages": [
       {
         "package": {
@@ -4234,7 +4233,7 @@
       "CVE-2022-25918",
       "GHSA-cr84-xvw4-qx3c"
     ],
-    "summary": "Inefficient Regular Expression Complexity in shescape ",
+    "summary": "Inefficient Regular Expression Complexity in shescape",
     "affected_packages": [
       {
         "package": {

vulnerabilities/tests/test_data/mozilla/expected-yml.json

@@ -3,7 +3,7 @@
     "aliases": [
       "CVE-2022-22746"
     ],
-    "summary": "A race condition could have allowed bypassing the fullscreen notification which could have lead to a fullscreen window spoof being unnoticed.*This bug only affects Firefox for Windows. Other operating systems are unaffected.*\n",
+    "summary": "A race condition could have allowed bypassing the fullscreen notification which could have lead to a fullscreen window spoof being unnoticed.*This bug only affects Firefox for Windows. Other operating systems are unaffected.*",
     "affected_packages": [
       {
         "package": {
@@ -38,7 +38,7 @@
     "aliases": [
       "CVE-2022-22743"
     ],
-    "summary": "When navigating from inside an iframe while requesting fullscreen access, an attacker-controlled tab could have made the browser unable to leave fullscreen mode.\n",
+    "summary": "When navigating from inside an iframe while requesting fullscreen access, an attacker-controlled tab could have made the browser unable to leave fullscreen mode.",
     "affected_packages": [],
     "references": [
       {
@@ -60,7 +60,7 @@
     "aliases": [
       "CVE-2022-22742"
     ],
-    "summary": "When inserting text while in edit mode, some characters might have lead to out-of-bounds memory access causing a potentially exploitable crash.\n",
+    "summary": "When inserting text while in edit mode, some characters might have lead to out-of-bounds memory access causing a potentially exploitable crash.",
     "affected_packages": [],
     "references": [
       {
@@ -82,7 +82,7 @@
     "aliases": [
       "CVE-2022-22741"
     ],
-    "summary": "When resizing a popup while requesting fullscreen access, the popup would have become unable to leave fullscreen mode.\n",
+    "summary": "When resizing a popup while requesting fullscreen access, the popup would have become unable to leave fullscreen mode.",
     "affected_packages": [],
     "references": [
       {
@@ -104,7 +104,7 @@
     "aliases": [
       "CVE-2022-22740"
     ],
-    "summary": "Certain network request objects were freed too early when releasing a network request handle. This could have lead to a use-after-free causing a potentially exploitable crash.\n",
+    "summary": "Certain network request objects were freed too early when releasing a network request handle. This could have lead to a use-after-free causing a potentially exploitable crash.",
     "affected_packages": [],
     "references": [
       {
@@ -126,7 +126,7 @@
     "aliases": [
       "CVE-2022-22738"
     ],
-    "summary": "Applying a CSS filter effect could have accessed out of bounds memory. This could have lead to a heap-buffer-overflow causing a potentially exploitable crash.\n",
+    "summary": "Applying a CSS filter effect could have accessed out of bounds memory. This could have lead to a heap-buffer-overflow causing a potentially exploitable crash.",
     "affected_packages": [],
     "references": [
       {
@@ -148,7 +148,7 @@
     "aliases": [
       "CVE-2022-22737"
     ],
-    "summary": "Constructing audio sinks could have lead to a race condition when playing audio files and closing windows. This could have lead to a use-after-free causing a potentially exploitable crash.\n",
+    "summary": "Constructing audio sinks could have lead to a race condition when playing audio files and closing windows. This could have lead to a use-after-free causing a potentially exploitable crash.",
     "affected_packages": [],
     "references": [
       {
@@ -170,7 +170,7 @@
     "aliases": [
       "CVE-2021-4140"
     ],
-    "summary": "It was possible to construct specific XSLT markup that would be able to bypass an iframe sandbox.\n",
+    "summary": "It was possible to construct specific XSLT markup that would be able to bypass an iframe sandbox.",
     "affected_packages": [],
     "references": [
       {
@@ -192,7 +192,7 @@
     "aliases": [
       "CVE-2022-22750"
     ],
-    "summary": "By generally accepting and passing resource handles across processes, a compromised content process might have confused higher privileged processes to interact with handles that the unprivileged process should not have access to.*This bug only affects Firefox for Windows and MacOS. Other operating systems are unaffected.*\n",
+    "summary": "By generally accepting and passing resource handles across processes, a compromised content process might have confused higher privileged processes to interact with handles that the unprivileged process should not have access to.*This bug only affects Firefox for Windows and MacOS. Other operating systems are unaffected.*",
     "affected_packages": [],
     "references": [
       {
@@ -214,7 +214,7 @@
     "aliases": [
       "CVE-2022-22749"
     ],
-    "summary": "When scanning QR codes, Firefox for Android would have allowed navigation to some URLs that do not point to web content.*This bug only affects Firefox for Android. Other operating systems are unaffected.*\n",
+    "summary": "When scanning QR codes, Firefox for Android would have allowed navigation to some URLs that do not point to web content.*This bug only affects Firefox for Android. Other operating systems are unaffected.*",
     "affected_packages": [],
     "references": [
       {
@@ -236,7 +236,7 @@
     "aliases": [
       "CVE-2022-22748"
     ],
-    "summary": "Malicious websites could have confused Firefox into showing the wrong origin when asking to launch a program and handling an external URL protocol.\n",
+    "summary": "Malicious websites could have confused Firefox into showing the wrong origin when asking to launch a program and handling an external URL protocol.",
     "affected_packages": [],
     "references": [
       {
@@ -258,7 +258,7 @@
     "aliases": [
       "CVE-2022-22745"
     ],
-    "summary": "Securitypolicyviolation events could have leaked cross-origin information for frame-ancestors violations\n",
+    "summary": "Securitypolicyviolation events could have leaked cross-origin information for frame-ancestors violations",
     "affected_packages": [],
     "references": [
       {
@@ -280,7 +280,7 @@
     "aliases": [
       "CVE-2022-22744"
     ],
-    "summary": "The constructed curl command from the \"Copy as curl\" feature in DevTools was not properly escaped for PowerShell.  This could have lead to command injection if pasted into a Powershell prompt.*This bug only affects Firefox for Windows. Other operating systems are unaffected.*\n",
+    "summary": "The constructed curl command from the \"Copy as curl\" feature in DevTools was not properly escaped for PowerShell.  This could have lead to command injection if pasted into a Powershell prompt.*This bug only affects Firefox for Windows. Other operating systems are unaffected.*",
     "affected_packages": [],
     "references": [
       {
@@ -302,7 +302,7 @@
     "aliases": [
       "CVE-2022-22763"
     ],
-    "summary": "When a worker is shutdown, it was possible to cause script to run late in the lifecycle, at a point after where it should not be possible.\n",
+    "summary": "When a worker is shutdown, it was possible to cause script to run late in the lifecycle, at a point after where it should not be possible.",
     "affected_packages": [],
     "references": [
       {
@@ -324,7 +324,7 @@
     "aliases": [
       "CVE-2022-22747"
     ],
-    "summary": "After accepting an untrusted certificate, handling an empty pkcs7 sequence as part of the certificate data could have lead to a crash. This crash is believed to be unexploitable.\n",
+    "summary": "After accepting an untrusted certificate, handling an empty pkcs7 sequence as part of the certificate data could have lead to a crash. This crash is believed to be unexploitable.",
     "affected_packages": [],
     "references": [
       {
@@ -346,7 +346,7 @@
     "aliases": [
       "CVE-2022-22736"
     ],
-    "summary": "If Firefox was installed to a world-writable directory, a local privilege escalation could occur when Firefox searched the current directory for system libraries. However the install directory is not world-writable by default.*This bug only affects Firefox for Windows in a non-default installation. Other operating systems are unaffected.*\n",
+    "summary": "If Firefox was installed to a world-writable directory, a local privilege escalation could occur when Firefox searched the current directory for system libraries. However the install directory is not world-writable by default.*This bug only affects Firefox for Windows in a non-default installation. Other operating systems are unaffected.*",
     "affected_packages": [],
     "references": [
       {
@@ -368,7 +368,7 @@
     "aliases": [
       "CVE-2022-22739"
     ],
-    "summary": "Malicious websites could have tricked users into accepting launching a program to handle an external URL protocol.\n",
+    "summary": "Malicious websites could have tricked users into accepting launching a program to handle an external URL protocol.",
     "affected_packages": [],
     "references": [
       {
@@ -390,7 +390,7 @@
     "aliases": [
       "CVE-2022-22751"
     ],
-    "summary": "Mozilla developers Calixte Denizet, Kershaw Chang, Christian Holler, Jason Kratzer, Gabriele Svelto, Tyson Smith, Simon Giesecke, and Steve Fink reported memory safety bugs present in Firefox 95 and Firefox ESR 91.4. Some of these bugs showed evidence of memory corruption and we presume that with enough effort some of these could have been exploited to run arbitrary code.\n",
+    "summary": "Mozilla developers Calixte Denizet, Kershaw Chang, Christian Holler, Jason Kratzer, Gabriele Svelto, Tyson Smith, Simon Giesecke, and Steve Fink reported memory safety bugs present in Firefox 95 and Firefox ESR 91.4. Some of these bugs showed evidence of memory corruption and we presume that with enough effort some of these could have been exploited to run arbitrary code.",
     "affected_packages": [],
     "references": [
       {
@@ -412,7 +412,7 @@
     "aliases": [
       "CVE-2022-22752"
     ],
-    "summary": "Mozilla developers Christian Holler and Jason Kratzer reported memory safety bugs present in Firefox 95. Some of these bugs showed evidence of memory corruption and we presume that with enough effort some of these could have been exploited to run arbitrary code.\n",
+    "summary": "Mozilla developers Christian Holler and Jason Kratzer reported memory safety bugs present in Firefox 95. Some of these bugs showed evidence of memory corruption and we presume that with enough effort some of these could have been exploited to run arbitrary code.",
     "affected_packages": [],
     "references": [
       {

vulnerabilities/tests/test_import_runner.py

@@ -105,4 +105,4 @@ def test_advisory_summary_clean_up():
     adv = AdvisoryData(
         summary="The X509Extension in pyOpenSSL before 0.13.1 does not properly handle a '\x00' character in a domain name in the Subject Alternative Name field of an X.509 certificate, which allows man-in-the-middle attackers to spoof arbitrary SSL servers via a crafted certificate issued by a legitimate Certification Authority."
     )
-    assert '\x00' not in adv.summary
+    assert "\x00" not in adv.summary