Skip to content

Commit de20880

Browse files
committed
Add success message for user creation
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 761fe6c commit de20880

3 files changed

Lines changed: 23 additions & 7 deletions

File tree

vulnerabilities/forms.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ class Meta:
4747
)
4848

4949
def __init__(self, *args, **kwargs):
50-
super(ApiUserCreationForm, self).__init__(*args, **kwargs)
50+
super(ApiUserCreationForm, self).__init__(*args, **kwargs)
5151
self.fields["username"].help_text = f"<ul><li>{self.fields['username'].help_text}</li></ul>"
52+
self.fields["username"].label = "Email"
5253

5354
def save(self, commit=True):
5455
return ApiUser.objects.create_api_user(

vulnerabilities/templates/api_user_creation_form.html

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@
44

55
{% block content %}
66
<section class="section pt-0">
7+
{% for message in messages %}
8+
<article class="message is-{% if message.level_tag == 'error' %}danger{% else %}{{ message.level_tag }}{% endif %}">
9+
<div class="message-body">
10+
{{ message|linebreaksbr }}
11+
</div>
12+
</article>
13+
{% endfor %}
714
{% block title %}
815
VulnerableCode API key request
916
{% endblock %}

vulnerabilities/views.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
from django.core.mail import send_mail
1111
from django.db.models import Count
1212
from django.db.models import Q
13-
from django.http import HttpResponse
1413
from django.http.response import Http404
1514
from django.shortcuts import render
1615
from django.urls import reverse_lazy
1716
from django.views import View
1817
from django.views import generic
1918
from django.views.generic.detail import DetailView
19+
from django.contrib import messages
2020
from django.views.generic.list import ListView
2121
from packageurl import PackageURL
2222

@@ -235,18 +235,26 @@ class ApiUserCreateView(generic.CreateView):
235235
template_name = "api_user_creation_form.html"
236236

237237
def form_valid(self, form):
238-
super().form_valid(form)
238+
response = super().form_valid(form)
239239

240240
send_mail(
241241
subject="VulnerableCode.io API key token",
242242
message=f"Here is your VulnerableCode.io API key token: {self.object.auth_token}",
243243
from_email=env.str("FROM_EMAIL", default=""),
244244
recipient_list=[self.object.email],
245+
fail_silently=True,
245246
)
246247

247-
return HttpResponse(
248-
f"Check your email for VulnerableCode.io API key token: {self.object.email}"
249-
)
248+
messages.success(self.request, f"API key token sent to your email address {self.object.email}.")
249+
250+
return response
251+
252+
def form_invalid(self, form):
253+
response = super().form_invalid(form)
254+
255+
messages.error(self.request, str(form.errors))
256+
257+
return response
250258

251259
def get_success_url(self):
252-
return reverse_lazy("home")
260+
return reverse_lazy("api_user_request")

0 commit comments

Comments
 (0)