test: add tests for ruby

Author: EslamHiko

vulnerabilities/scraper/ruby.py

@@ -37,41 +37,47 @@ def get_patched_range(spec_list):
         yield RangeSpecifier(spec)
 
 
-def import_vulnerabilities():
-    vulnerability_package_dicts = []
-    for vulnerability in rubygem_advisories(RUBYSEC_DB_URL):
+def load_vulnerability_package(vulnerability):
+    package_name = vulnerability.get(
+        'gem')
 
-        package_name = vulnerability.get(
-            'gem')
+    if not package_name:
+        return
 
-        if not package_name:
-            continue
+    if 'cve' in vulnerability:
+        vulnerability_id = 'CVE-{}'.format(vulnerability['cve'])
+    else:
+        return
 
-        if 'cve' in vulnerability:
-            vulnerability_id = 'CVE-{}'.format(vulnerability['cve'])
-        else:
-            continue
+    advisory_url = vulnerability.get('url')
+    patched_version_ranges = list(
+        get_patched_range(
+            vulnerability.get('patched_versions', [])))
+    all_versions = set(get_all_versions_of_package(package_name))
+    unaffected_versions = set()
+
+    if patched_version_ranges:
+        for version in all_versions:
+            for spec in patched_version_ranges:
+                if version in spec:
+                    unaffected_versions.add(version)
+                    break
+
+    affected_versions = all_versions - unaffected_versions
+
+    return {
+        'package_name': package_name,
+        'cve_id': vulnerability_id,
+        'fixed_versions': unaffected_versions,
+        'affected_versions': affected_versions,
+        'advisory': advisory_url
+    }
+
+
+def import_vulnerabilities():
+    vulnerability_package_dicts = []
+    for vulnerability in rubygem_advisories(RUBYSEC_DB_URL):
+        package = load_vulnerability_package(vulnerability)
+        vulnerability_package_dicts.append(package)
 
-        advisory_url = vulnerability.get('url')
-        patched_version_ranges = list(
-            get_patched_range(
-                vulnerability.get('patched_versions', [])))
-        all_versions = set(get_all_versions_of_package(package_name))
-        unaffected_versions = set()
-
-        if patched_version_ranges:
-            for version in all_versions:
-                for spec in patched_version_ranges:
-                    if version in spec:
-                        unaffected_versions.add(version)
-                        break
-
-        affected_versions = all_versions - unaffected_versions
-        vulnerability_package_dicts.append({
-            'package_name': package_name,
-            'cve_id': vulnerability_id,
-            'fixed_versions': unaffected_versions,
-            'affected_versions': affected_versions,
-            'advisory': advisory_url
-        })
     return vulnerability_package_dicts

vulnerabilities/tests/test_ruby.py

@@ -0,0 +1,39 @@
+# Author: Islam ElHakmi (@EslamHiko)
+# Copyright (c) 2017 nexB Inc. and others. All rights reserved.
+# http://nexb.com and https://github.com/nexB/vulnerablecode/
+# The VulnerableCode software is licensed under the Apache License version 2.0.
+# Data generated with VulnerableCode require an acknowledgment.
+#
+# You may not use this software except in compliance with the License.
+# You may obtain a copy of the License at: http://apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations under the License.
+#
+# When you publish or redistribute any data created with VulnerableCode or any VulnerableCode
+# derivative work, you must accompany this data with the following acknowledgment:
+#
+#  Generated with VulnerableCode and provided on an "AS IS" BASIS, WITHOUT WARRANTIES
+#  OR CONDITIONS OF ANY KIND, either express or implied. No content created from
+#  VulnerableCode should be considered or used as legal advice. Consult an Attorney
+#  for any legal advice.
+#  VulnerableCode is a free software code scanning tool from nexB Inc. and others.
+#  Visit https://github.com/nexB/vulnerablecode/ for support and download.
+
+import pytest
+from vulnerabilities.scraper.ruby import rubygem_advisories
+from vulnerabilities.scraper.ruby import load_vulnerability_package
+
+RUBYSEC_DB_URL = 'https://github.com/rubysec/ruby-advisory-db/archive/master.zip'
+
+
+@pytest.mark.webtest
+def test_extract_data():
+    for vulnerability in rubygem_advisories(RUBYSEC_DB_URL):
+        package = load_vulnerability_package(vulnerability)
+        assert len(package['package_name']) != 0
+        assert len(package['cve_id']) != 0
+        assert len(package['affected_versions']) != 0
+        assert len(package['advisory']) != 0
+        break