Split up data dump tests into separate classes and methods

Signed-off-by: Haiko Schol <hs@haikoschol.com>

Author: haikoschol

vulnerabilities/tests/test_data_dump.py

@@ -44,71 +44,125 @@
 TEST_DATA = os.path.join(BASE_DIR, 'test_data/')
 
 
-class TestDataDump(TestCase):
-    def test_debian_data_dump(self):
-        """
-        Scrape data from Debian' main tracker, save it
-        in the database and verify entries.
-        """
+class TestDebianDataDump(TestCase):
+
+    @classmethod
+    def setUpTestData(self):
         with open(os.path.join(TEST_DATA, 'debian.json')) as f:
             test_data = json.load(f)
 
         extract_data = debian.extract_vulnerabilities(test_data)
         debian_dump(extract_data)
 
+    def test_Vulnerability(self):
+        """
+        Check that all vulnerabilities from the test data are stored in the database
+        """
         self.assertEqual(3, Vulnerability.objects.count())
-        self.assertEqual(3, VulnerabilityReference.objects.count())
-        self.assertEqual(3, Package.objects.count())
 
         self.assertTrue(Vulnerability.objects.get(
                         summary='Multiple stack-based buffer overflows in mimetex.cgi in mimeTeX'))
 
         self.assertTrue(Vulnerability.objects.get(
                         summary='Multiple unspecified vulnerabilities in mimeTeX'))
 
+        self.assertTrue(Vulnerability.objects.get(
+                        summary='librsync before 1.0.0 uses a truncated MD4 checksum \
+to match blocks'))
+
+    def test_VulnerabilityReference(self):
+        """
+        Check that all vulnerability references from the test data are stored in the database
+        """
+        self.assertEqual(3, VulnerabilityReference.objects.count())
         self.assertTrue(VulnerabilityReference.objects.get(reference_id='CVE-2009-1382'))
         self.assertTrue(VulnerabilityReference.objects.get(reference_id='CVE-2009-2459'))
         self.assertTrue(VulnerabilityReference.objects.get(reference_id='CVE-2014-8242'))
-        self.assertTrue(Package.objects.get(name='librsync'))
 
-    def test_ubuntu_data_dump(self):
+    def test_Package(self):
         """
-        Scrape data from Ubuntu' main tracker, save it
-        in the database and verify entries.
+        Check that all packages from the test data are stored in the database
         """
+        # There are three rows in Package because currently the models allow duplicates
+        # (see issue #28).
+        self.assertEqual(3, Package.objects.count())
+
+        self.assertTrue(Package.objects.filter(name='mimetex'))
+        self.assertTrue(Package.objects.get(name='librsync'))
+
+
+class TestUbuntuDataDump(TestCase):
+    @classmethod
+    def setUpTestData(self):
         with open(os.path.join(TEST_DATA, 'ubuntu_main.html')) as f:
             test_data = f.read()
 
         data = ubuntu.extract_cves(test_data)
         ubuntu_dump(data)
 
+    def test_data_dump(self):
+        """
+        Check basic data import
+        """
         reference = VulnerabilityReference.objects.filter(reference_id='CVE-2002-2439')[0]
         self.assertEqual(reference.reference_id, 'CVE-2002-2439')
         self.assertTrue(Package.objects.filter(name='gcc-4.6')[0].name, 'gcc-4.6')
 
-    def test_archlinux_data_dump(self):
-        """
-        Scrape data from Archlinux' main tracker, save it
-        in the database and verify entries.
-        """
+
+class TestArchLinuxDataDump(TestCase):
+
+    @classmethod
+    def setUpTestData(self):
         with open(os.path.join(TEST_DATA, 'archlinux.json')) as f:
-            test_data = json.loads(f.read())
+            test_data = json.load(f)
 
         archlinux_dump(test_data)
 
+    def test_Vulnerability(self):
+        """
+        Check that all vulnerabilities from the test data are stored in the database
+        """
         self.assertEqual(1, Vulnerability.objects.count())
+        self.assertTrue(Vulnerability.objects.get(summary='multiple issues'))
+
+    def test_VulnerabilityReference(self):
+        """
+        Check that all vulnerability references from the test data are stored in the database
+        """
         self.assertEqual(14, VulnerabilityReference.objects.count())
+        self.assertTrue(VulnerabilityReference.objects.get(reference_id='CVE-2018-11360'))
+        self.assertTrue(VulnerabilityReference.objects.get(reference_id='ASA-201805-24'))
+        self.assertTrue(VulnerabilityReference.objects.get(reference_id='AVG-708'))
+
+    def test_Package(self):
+        """
+        Check that all packages from the test data are stored in the database
+        """
         self.assertEqual(8, Package.objects.count())
-        self.assertEqual(8, PackageReference.objects.count())
-        self.assertEqual(4, ImpactedPackage.objects.count())
-        self.assertEqual(4, ResolvedPackage.objects.count())
+        self.assertTrue(Package.objects.filter(name='wireshark-cli'))
 
-        self.assertTrue(Vulnerability.objects.get(summary='multiple issues'))
+    def test_PackageReference(self):
+        """
+        Check that all package references from the test data are stored in the database
+        """
+        self.assertEqual(8, PackageReference.objects.count())
 
-        self.assertTrue(VulnerabilityReference.objects.get(reference_id='CVE-2018-11360'))
+    def test_ImpactedPackage(self):
+        """
+        Check that all impacted packages from the test data are stored in the database
+        """
+        impacted_pkgs = ImpactedPackage.objects.all()
+        impacted_pkg = impacted_pkgs[0]
 
-        self.assertTrue(VulnerabilityReference.objects.get(reference_id='ASA-201805-24'))
+        self.assertEqual(4, len(impacted_pkgs))
+        self.assertEqual('2.6.0-1', impacted_pkg.package.version)
 
-        self.assertTrue(VulnerabilityReference.objects.get(reference_id='AVG-708'))
+    def test_ResolvedPackage(self):
+        """
+        Check that all resolved packages from the test data are stored in the database
+        """
+        resolved_pkgs = ResolvedPackage.objects.all()
+        resolved_pkg = resolved_pkgs[0]
 
-        self.assertEqual(Package.objects.filter(name='wireshark-cli')[0].name, 'wireshark-cli')
+        self.assertEqual(4, len(resolved_pkgs))
+        self.assertEqual('2.6.1-1', resolved_pkg.package.version)