diff --git a/vulnerabilities/api.py b/vulnerabilities/api.py index af8e5d889..137fe2dd6 100644 --- a/vulnerabilities/api.py +++ b/vulnerabilities/api.py @@ -97,7 +97,6 @@ class Meta: class VulnerabilitySerializer(serializers.HyperlinkedModelSerializer): - fixed_packages = MinimalPackageSerializer( many=True, source="filtered_fixed_packages", read_only=True ) diff --git a/vulnerabilities/forms.py b/vulnerabilities/forms.py index 793936c72..84fe31bb1 100644 --- a/vulnerabilities/forms.py +++ b/vulnerabilities/forms.py @@ -14,7 +14,6 @@ class PackageSearchForm(forms.Form): - search = forms.CharField( required=True, widget=forms.TextInput( @@ -24,7 +23,6 @@ class PackageSearchForm(forms.Form): class VulnerabilitySearchForm(forms.Form): - search = forms.CharField( required=True, widget=forms.TextInput( diff --git a/vulnerabilities/importer.py b/vulnerabilities/importer.py index 21f4b5d26..08bed89fe 100644 --- a/vulnerabilities/importer.py +++ b/vulnerabilities/importer.py @@ -73,7 +73,6 @@ def from_dict(cls, severity: dict): @dataclasses.dataclass(order=True) class Reference: - reference_id: str = "" url: str = "" severities: List[VulnerabilitySeverity] = dataclasses.field(default_factory=list) diff --git a/vulnerabilities/importers/alpine_linux.py b/vulnerabilities/importers/alpine_linux.py index b4a05e8b7..3151ffb93 100644 --- a/vulnerabilities/importers/alpine_linux.py +++ b/vulnerabilities/importers/alpine_linux.py @@ -156,7 +156,6 @@ def load_advisories( vuln_ids = vuln_ids[1:] references = [] for reference_id in vuln_ids: - if reference_id.startswith("XSA"): references.append(XsaReference.from_id(xsa_id=reference_id)) diff --git a/vulnerabilities/importers/apache_httpd.py b/vulnerabilities/importers/apache_httpd.py index 6f120addd..d692518ac 100644 --- a/vulnerabilities/importers/apache_httpd.py +++ b/vulnerabilities/importers/apache_httpd.py @@ -44,7 +44,6 @@ class ApacheHTTPDImporter(Importer): - base_url = "https://httpd.apache.org/security/json/" spdx_license_expression = "Apache-2.0" license_url = "https://www.apache.org/licenses/LICENSE-2.0" diff --git a/vulnerabilities/importers/apache_kafka.py b/vulnerabilities/importers/apache_kafka.py index 96b55748f..5705183db 100644 --- a/vulnerabilities/importers/apache_kafka.py +++ b/vulnerabilities/importers/apache_kafka.py @@ -86,7 +86,6 @@ class ApacheKafkaImporter(Importer): - GH_PAGE_URL = "https://raw.githubusercontent.com/apache/kafka-site/asf-site/cve-list.html" ASF_PAGE_URL = "https://kafka.apache.org/cve-list" spdx_license_expression = "Apache-2.0" diff --git a/vulnerabilities/importers/apache_tomcat.py b/vulnerabilities/importers/apache_tomcat.py index 3d754d6df..3bb6e87cf 100644 --- a/vulnerabilities/importers/apache_tomcat.py +++ b/vulnerabilities/importers/apache_tomcat.py @@ -115,7 +115,6 @@ class ApacheTomcatImporter(Importer): - spdx_license_expression = "Apache-2.0" license_url = "https://www.apache.org/licenses/LICENSE-2.0" @@ -404,7 +403,6 @@ def to_version_ranges_apache(versions_data, fixed_versions): ) for fixed_item in fixed_versions: - if "-" in fixed_item and not any([i.isalpha() for i in fixed_item]): fixed_item_split = fixed_item.split(" ") fixed_constraint_tuple_list.append(VersionConstraintTuple(">=", fixed_item_split[0])) @@ -495,7 +493,6 @@ def to_version_ranges_maven(versions_data, fixed_versions): ) for fixed_item in fixed_versions: - if "-" in fixed_item and not any([i.isalpha() for i in fixed_item]): fixed_item_split = fixed_item.split(" ") diff --git a/vulnerabilities/importers/debian.py b/vulnerabilities/importers/debian.py index 5191639db..5816a96ec 100644 --- a/vulnerabilities/importers/debian.py +++ b/vulnerabilities/importers/debian.py @@ -38,7 +38,6 @@ class DebianImporter(Importer): - spdx_license_expression = "LicenseRef-scancode-other-permissive" license_url = "https://www.debian.org/license" notice = """ @@ -226,7 +225,10 @@ def get_inferences(self, advisory_data: AdvisoryData) -> Iterable[Inference]: vulnerable_packages=affected_purls, resolved_packages=fixed_purls ) - for (fixed_package, affected_packages,) in get_affected_packages_by_patched_package( + for ( + fixed_package, + affected_packages, + ) in get_affected_packages_by_patched_package( affected_packages=affected_packages ).items(): yield Inference.from_advisory_data( diff --git a/vulnerabilities/importers/debian_oval.py b/vulnerabilities/importers/debian_oval.py index 33f5c4e9f..1acac0aee 100644 --- a/vulnerabilities/importers/debian_oval.py +++ b/vulnerabilities/importers/debian_oval.py @@ -16,7 +16,6 @@ class DebianOvalImporter(OvalImporter): - spdx_license_expression = "LicenseRef-scancode-other-permissive" license_url = "https://www.debian.org/license" notice = """ diff --git a/vulnerabilities/importers/elixir_security.py b/vulnerabilities/importers/elixir_security.py index a1d0a33cf..bb5695161 100644 --- a/vulnerabilities/importers/elixir_security.py +++ b/vulnerabilities/importers/elixir_security.py @@ -22,7 +22,6 @@ class ElixirSecurityImporter(Importer): - repo_url = "git+https://github.com/dependabot/elixir-security-advisories" license_url = "https://github.com/dependabot/elixir-security-advisories/blob/master/LICENSE.txt" spdx_license_expression = "CC0-1.0" diff --git a/vulnerabilities/importers/istio.py b/vulnerabilities/importers/istio.py index 951fa5297..603bd8764 100644 --- a/vulnerabilities/importers/istio.py +++ b/vulnerabilities/importers/istio.py @@ -66,7 +66,6 @@ def advisory_data(self) -> Set[AdvisoryData]: yield from self.process_file(file) def process_file(self, path): - data = self.get_data_from_md(path) published_date = data.get("publishdate") release_date = None @@ -108,7 +107,6 @@ def process_file(self, path): ) for cve_id in data.get("cves") or []: - if not cve_id.startswith("CVE"): continue diff --git a/vulnerabilities/importers/nginx.py b/vulnerabilities/importers/nginx.py index 1320fc895..33adc9c2a 100644 --- a/vulnerabilities/importers/nginx.py +++ b/vulnerabilities/importers/nginx.py @@ -37,7 +37,6 @@ class NginxImporter(Importer): - url = "https://nginx.org/en/security_advisories.html" spdx_license_expression = "BSD-2-Clause" @@ -168,7 +167,6 @@ def parse_advisory_data_from_paragraph(vuln_info): ): aliases.append(text) if text.startswith("CVE-"): - # always keep the CVE as a reference too link = f"https://nvd.nist.gov/vuln/detail/{text}" reference = Reference(reference_id=text, url=link) diff --git a/vulnerabilities/importers/osv.py b/vulnerabilities/importers/osv.py index c4ee58685..9d13fe537 100644 --- a/vulnerabilities/importers/osv.py +++ b/vulnerabilities/importers/osv.py @@ -222,7 +222,6 @@ def get_fixed_versions(fixed_range, raw_id) -> List[Version]: fixed_range_type = fixed_range["type"] for version in extract_fixed_versions(fixed_range): - # FIXME: ECOSYSTEM does not imply PyPI!!!! if fixed_range_type == "ECOSYSTEM": try: diff --git a/vulnerabilities/importers/postgresql.py b/vulnerabilities/importers/postgresql.py index 8fbac9161..7b5ef85ed 100644 --- a/vulnerabilities/importers/postgresql.py +++ b/vulnerabilities/importers/postgresql.py @@ -24,7 +24,6 @@ class PostgreSQLImporter(Importer): - root_url = "https://www.postgresql.org/support/security/" license_url = "https://www.postgresql.org/about/licence/" spdx_license_expression = "PostgreSQL" diff --git a/vulnerabilities/importers/project_kb_msr2019.py b/vulnerabilities/importers/project_kb_msr2019.py index 9d281de72..184ba3952 100644 --- a/vulnerabilities/importers/project_kb_msr2019.py +++ b/vulnerabilities/importers/project_kb_msr2019.py @@ -17,7 +17,6 @@ class ProjectKBMSRImporter(Importer): - url = "https://raw.githubusercontent.com/SAP/project-kb/master/MSR2019/dataset/vulas_db_msr2019_release.csv" spdx_license_expression = "Apache-2.0" license_url = "https://github.com/SAP/project-kb/blob/main/LICENSE.txt" diff --git a/vulnerabilities/importers/redhat.py b/vulnerabilities/importers/redhat.py index 967f0dc38..858c0a605 100644 --- a/vulnerabilities/importers/redhat.py +++ b/vulnerabilities/importers/redhat.py @@ -61,7 +61,6 @@ def get_data_from_url(url): class RedhatImporter(Importer): - spdx_license_expression = "CC-BY-4.0" license_url = "https://access.redhat.com/documentation/en-us/red_hat_security_data_api/1.0/html/red_hat_security_data_api/legal-notice" diff --git a/vulnerabilities/importers/ruby.py b/vulnerabilities/importers/ruby.py index 1e116e3ff..57c247df5 100644 --- a/vulnerabilities/importers/ruby.py +++ b/vulnerabilities/importers/ruby.py @@ -115,7 +115,6 @@ def process_file(self, path) -> List[AdvisoryData]: @staticmethod def categorize_versions(all_versions, unaffected_version_ranges): - for id, elem in enumerate(unaffected_version_ranges): unaffected_version_ranges[id] = VersionRange.from_scheme_version_spec_string( "semver", elem diff --git a/vulnerabilities/importers/suse_backports.py b/vulnerabilities/importers/suse_backports.py index 6d661ef3f..f9e113fa1 100644 --- a/vulnerabilities/importers/suse_backports.py +++ b/vulnerabilities/importers/suse_backports.py @@ -36,7 +36,6 @@ def updated_advisories(self): return self.batch_advisories(advisories) def _fetch_yaml(self, url): - try: resp = requests.get(url) resp.raise_for_status() diff --git a/vulnerabilities/importers/suse_scores.py b/vulnerabilities/importers/suse_scores.py index 1a9f4c03a..c6d898ccd 100644 --- a/vulnerabilities/importers/suse_scores.py +++ b/vulnerabilities/importers/suse_scores.py @@ -21,7 +21,6 @@ class SUSESeverityScoreImporter(Importer): - spdx_license_expression = "CC-BY-4.0" license_url = "https://ftp.suse.com/pub/projects/security/yaml/LICENSE" diff --git a/vulnerabilities/importers/xen.py b/vulnerabilities/importers/xen.py index 07c62d1f9..af0d25d60 100644 --- a/vulnerabilities/importers/xen.py +++ b/vulnerabilities/importers/xen.py @@ -15,7 +15,6 @@ class XenImporter(Importer): - url = "https://xenbits.xen.org/xsa/xsa.json" spdx_license_expression = "LicenseRef-scancode-other-permissive" notice = """ diff --git a/vulnerabilities/improve_runner.py b/vulnerabilities/improve_runner.py index b6658d9ea..effc2e86b 100644 --- a/vulnerabilities/improve_runner.py +++ b/vulnerabilities/improve_runner.py @@ -80,7 +80,6 @@ def process_inferences(inferences: List[Inference], advisory: Advisory, improver continue for ref in inference.references: - reference = VulnerabilityReference.objects.get_or_none( reference_id=ref.reference_id, url=ref.url, diff --git a/vulnerabilities/lib_oval.py b/vulnerabilities/lib_oval.py index 6c8a6163f..7dede7f53 100644 --- a/vulnerabilities/lib_oval.py +++ b/vulnerabilities/lib_oval.py @@ -253,7 +253,6 @@ def writeToFile(self, filename): return False def to_string(self): - if not self.tree: return None diff --git a/vulnerabilities/management/commands/create_api_user.py b/vulnerabilities/management/commands/create_api_user.py index db471cac4..9f3166d4e 100644 --- a/vulnerabilities/management/commands/create_api_user.py +++ b/vulnerabilities/management/commands/create_api_user.py @@ -40,7 +40,6 @@ def add_arguments(self, parser): ) def handle(self, *args, **options): - email = options["email"] try: validate_email(email) diff --git a/vulnerabilities/management/commands/purl2cpe.py b/vulnerabilities/management/commands/purl2cpe.py index 277348615..b01088ec2 100644 --- a/vulnerabilities/management/commands/purl2cpe.py +++ b/vulnerabilities/management/commands/purl2cpe.py @@ -77,7 +77,6 @@ class Command(BaseCommand): help = "Dump a mapping of CPEs to PURLs grouped by vulnerability." def add_arguments(self, parser): - parser.add_argument( "--limit", default=0, diff --git a/vulnerabilities/oval_parser.py b/vulnerabilities/oval_parser.py index 94b360bff..3c14fb4e6 100755 --- a/vulnerabilities/oval_parser.py +++ b/vulnerabilities/oval_parser.py @@ -25,7 +25,6 @@ class OvalParser: def __init__(self, translations: Dict, oval_document: ET.ElementTree): - self.translations = translations self.oval_document = OvalDocument(oval_document) self.all_definitions = self.oval_document.getDefinitions() @@ -37,7 +36,6 @@ def get_data(self) -> List[Dict]: """ oval_data = [] for definition in self.all_definitions: - matching_tests = self.get_tests_of_definition(definition) if not matching_tests: continue @@ -72,7 +70,6 @@ def get_tests_of_definition(self, definition: OvalDefinition) -> List[OvalTest]: criteria_refs = [] for child in definition.element.iter(): - if "test_ref" in child.attrib: criteria_refs.append(child.get("test_ref")) diff --git a/vulnerabilities/package_managers.py b/vulnerabilities/package_managers.py index f210f0f98..7bed51734 100644 --- a/vulnerabilities/package_managers.py +++ b/vulnerabilities/package_managers.py @@ -645,7 +645,6 @@ def fetch_version_info(version_info: str, escaped_pkg: str) -> Optional[PackageV return PackageVersion(value=value, release_date=release_date) def fetch(self, pkg: str) -> Iterable[PackageVersion]: - # escape uppercase in module path escaped_pkg = self.escape_path(pkg) trimmed_pkg = pkg diff --git a/vulnerabilities/rpm_utils.py b/vulnerabilities/rpm_utils.py index 206f3668f..4bb672728 100644 --- a/vulnerabilities/rpm_utils.py +++ b/vulnerabilities/rpm_utils.py @@ -17,6 +17,7 @@ # This code has been vendored from scancode. + # https://github.com/nexB/scancode-toolkit/blob/16ae20a343c5332114edac34c7b6fcf2fb6bca74/src/packagedcode/rpm.py#L91 class EVR(namedtuple("EVR", "epoch version release")): """ diff --git a/vulnerabilities/tests/example_importer_improver.py b/vulnerabilities/tests/example_importer_improver.py index 8717d607d..5d0d741d7 100644 --- a/vulnerabilities/tests/example_importer_improver.py +++ b/vulnerabilities/tests/example_importer_improver.py @@ -29,7 +29,6 @@ class ExampleImporter(Importer): - spdx_license_expression = "BSD-2-Clause" def advisory_data(self) -> Iterable[AdvisoryData]: diff --git a/vulnerabilities/tests/test_api.py b/vulnerabilities/tests/test_api.py index d02808e16..b008ced49 100644 --- a/vulnerabilities/tests/test_api.py +++ b/vulnerabilities/tests/test_api.py @@ -88,7 +88,6 @@ def setUp(self): self.client.credentials(HTTP_AUTHORIZATION=self.auth) def test_query_qualifier_filtering(self): - # packages to check filtering with single/multiple and unordered qualifier filtering pk_multi_qf = Package.objects.create( name="vlc", version="1.50-1.1", type="deb", qualifiers={"foo": "bar", "tar": "ball"} diff --git a/vulnerabilities/tests/test_data_source.py b/vulnerabilities/tests/test_data_source.py index b2f173029..4692425ad 100644 --- a/vulnerabilities/tests/test_data_source.py +++ b/vulnerabilities/tests/test_data_source.py @@ -63,7 +63,6 @@ def test_create_purl(): def test__collect_pkgs(): - xmls = load_oval_data() expected_suse_pkgs = {"cacti-spine", "apache2-mod_perl", "cacti", "apache2-mod_perl-devel"} diff --git a/vulnerabilities/tests/test_example.py b/vulnerabilities/tests/test_example.py index 539d3bfb3..454b86d61 100644 --- a/vulnerabilities/tests/test_example.py +++ b/vulnerabilities/tests/test_example.py @@ -52,7 +52,6 @@ def mock_fetch_additional_aliases(alias): mock_fetch_additional_aliases, ) class TestExampleImporter(testcase.FileBasedTesting): - test_data_dir = str(Path(__file__).resolve().parent / "test_data" / "example") def test_parse_advisory_data(self): diff --git a/vulnerabilities/tests/test_nginx.py b/vulnerabilities/tests/test_nginx.py index 7f8da680f..7b668def7 100644 --- a/vulnerabilities/tests/test_nginx.py +++ b/vulnerabilities/tests/test_nginx.py @@ -149,7 +149,6 @@ def test_advisory_data_from_text(self): @pytest.mark.django_db(transaction=True) def test_NginxImporter(self): - expected_file = self.get_test_loc( "security_advisories-importer-expected.json", must_exist=False ) @@ -221,7 +220,6 @@ def test_NginxBasicImprover_fetch_nginx_version_from_git_tags(self, mock_fetcher @pytest.mark.django_db(transaction=True) def test_NginxBasicImprover__get_inferences_from_versions_end_to_end(self): - with open(self.get_test_loc("improver/improver-advisories.json")) as vf: advisories_data = json.load(vf) diff --git a/vulnerabilities/tests/test_nvd.py b/vulnerabilities/tests/test_nvd.py index af7e2f19b..c2b3cf866 100644 --- a/vulnerabilities/tests/test_nvd.py +++ b/vulnerabilities/tests/test_nvd.py @@ -56,7 +56,6 @@ def test_to_advisories_skips_hardware(regen=REGEN): # TODO: use a JSON fixtures instead def get_test_cve_item(): - return { "cve": { "data_type": "CVE", diff --git a/vulnerabilities/tests/test_openssl.py b/vulnerabilities/tests/test_openssl.py index 76d6c320a..65312582c 100644 --- a/vulnerabilities/tests/test_openssl.py +++ b/vulnerabilities/tests/test_openssl.py @@ -117,7 +117,6 @@ def test_to_advisory_data(self): @pytest.mark.django_db(transaction=True) def test_OpensslImporter(self): - expected_file = self.get_test_loc( "security_advisories-importer-expected.json", must_exist=False ) @@ -153,7 +152,6 @@ def fetch(self): @pytest.mark.django_db(transaction=True) def test_DefaultImprover_inferences_on_Openssl(self): - with open(self.get_test_loc("improver/improver-advisories.json")) as vf: advisories_data = json.load(vf) diff --git a/vulnerabilities/tests/test_package_managers.py b/vulnerabilities/tests/test_package_managers.py index 228c32fd2..f921f9c15 100644 --- a/vulnerabilities/tests/test_package_managers.py +++ b/vulnerabilities/tests/test_package_managers.py @@ -107,7 +107,6 @@ def test_pypi_fetch_with_no_release(mock_response): @mock.patch("vulnerabilities.package_managers.get_response") def test_ruby_fetch_with_no_release(mock_response): - with open(os.path.join(TEST_DATA, "gem.json")) as f: mock_response.return_value = json.load(f) @@ -122,7 +121,6 @@ def test_ruby_fetch_with_no_release(mock_response): class TestComposerVersionAPI: - expected_versions = [ PackageVersion(value=("10.0.0",), release_date=dt_local(2019, 7, 23, 7, 6, 3)), PackageVersion(value=("10.1.0",), release_date=dt_local(2019, 10, 1, 8, 18, 18)), @@ -257,7 +255,6 @@ def test_fetch(self, mock_response): class TestGoproxyVersionAPI: def test_trim_go_url_path(self): - url1 = "https://pkg.go.dev/github.com/containous/traefik/v2" assert GoproxyVersionAPI.trim_go_url_path(url1) == "github.com/containous/traefik" diff --git a/vulnerabilities/tests/test_ruby.py b/vulnerabilities/tests/test_ruby.py index e57026fe3..6bbe61de3 100644 --- a/vulnerabilities/tests/test_ruby.py +++ b/vulnerabilities/tests/test_ruby.py @@ -128,7 +128,6 @@ def test_process_file(self, mock_write): assert sorted(found_advisories) == sorted(expected_advisories) def test_categorize_versions(self): - all_versions = ["1.0.0", "1.2.0", "9.0.2", "0.2.3"] safe_ver_ranges = ["==1.0.0", ">1.2.0"] diff --git a/vulnerabilities/tests/test_suse.py b/vulnerabilities/tests/test_suse.py index 5b2691b43..33109e8af 100644 --- a/vulnerabilities/tests/test_suse.py +++ b/vulnerabilities/tests/test_suse.py @@ -30,7 +30,6 @@ def setUp(self): self.definition_2 = self.parsed_oval.all_definitions[1] def test_get_definitions(self): - assert len(self.parsed_oval.all_definitions) == 2 assert ( self.parsed_oval.all_definitions[0].getId() == "oval:org.opensuse.security:def:20094112" @@ -40,7 +39,6 @@ def test_get_definitions(self): ) def test_get_tests_of_definition(self): - definition_1_test_ids = { "oval:org.opensuse.security:tst:2009281999", "oval:org.opensuse.security:tst:2009282000", @@ -59,7 +57,6 @@ def test_get_tests_of_definition(self): } def test_get_vuln_id_from_definition(self): - vuln_id_1 = "CVE-2009-4112" vuln_id_2 = "CVE-2011-2767" @@ -67,7 +64,6 @@ def test_get_vuln_id_from_definition(self): assert vuln_id_2 == self.parsed_oval.get_vuln_id_from_definition(self.definition_2) def test_get_object_state_of_test(self): - # This method is inherited as it is from UbuntuOvalParser # this test ensures that the method works with suse OVAL documents @@ -86,7 +82,6 @@ def test_get_object_state_of_test(self): assert obj_t1.getId() == "oval:org.opensuse.security:obj:2009031246" def test_get_pkgs_from_obj(self): - assert len(self.parsed_oval.oval_document.getObjects()) == 5 obj_t1 = self.parsed_oval.oval_document.getObjects()[0] @@ -101,7 +96,6 @@ def test_get_pkgs_from_obj(self): assert pkg_set2 == {"cacti"} def test_get_version_range_from_state(self): - assert len(self.parsed_oval.oval_document.getStates()) == 4 state_1 = self.parsed_oval.oval_document.getStates()[0] @@ -115,7 +109,6 @@ def test_get_version_range_from_state(self): assert self.parsed_oval.get_version_range_from_state(state_2) == exp_range_2 def test_get_urls_from_definition(self): - def1_urls = { "http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-4112", "https://www.suse.com/security/cve/CVE-2009-4112.html", @@ -134,7 +127,6 @@ def test_get_urls_from_definition(self): assert def2_urls == self.parsed_oval.get_urls_from_definition(self.definition_2) def test_get_data(self): - expected_data = [ { "test_data": [ diff --git a/vulnerabilities/tests/test_throttling.py b/vulnerabilities/tests/test_throttling.py index 5fbbebe80..690c92432 100644 --- a/vulnerabilities/tests/test_throttling.py +++ b/vulnerabilities/tests/test_throttling.py @@ -30,7 +30,6 @@ def setUp(self): self.staff_csrf_client.credentials(HTTP_AUTHORIZATION=self.staff_auth) def test_packages_endpoint_throttling(self): - # A basic user can only access /packages endpoint 10 times a day for i in range(0, 10): response = self.csrf_client.get("/api/packages") @@ -47,7 +46,6 @@ def test_packages_endpoint_throttling(self): self.assertEqual(response.status_code, 200) def test_cpes_endpoint_throttling(self): - # A basic user can only access /cpes endpoint 4 times a day for i in range(0, 4): response = self.csrf_client.get("/api/cpes") @@ -64,7 +62,6 @@ def test_cpes_endpoint_throttling(self): self.assertEqual(response.status_code, 200) def test_all_vulnerable_packages_endpoint_throttling(self): - # A basic user can only access /packages/all 1 time a day for i in range(0, 1): response = self.csrf_client.get("/api/packages/all") @@ -81,7 +78,6 @@ def test_all_vulnerable_packages_endpoint_throttling(self): self.assertEqual(response.status_code, 200) def test_vulnerabilities_endpoint_throttling(self): - # A basic user can only access /vulnerabilities 8 times a day for i in range(0, 8): response = self.csrf_client.get("/api/vulnerabilities") @@ -98,7 +94,6 @@ def test_vulnerabilities_endpoint_throttling(self): self.assertEqual(response.status_code, 200) def test_aliases_endpoint_throttling(self): - # A basic user can only access /alias 2 times a day for i in range(0, 2): response = self.csrf_client.get("/api/aliases") diff --git a/vulnerabilities/tests/test_utils.py b/vulnerabilities/tests/test_utils.py index ac21afc9a..5f5ed4bc4 100644 --- a/vulnerabilities/tests/test_utils.py +++ b/vulnerabilities/tests/test_utils.py @@ -21,7 +21,6 @@ def test_nearest_patched_package(): - result = nearest_patched_package( vulnerable_packages=[ PackageURL(type="npm", name="foo", version="2.0.4"), diff --git a/vulnerabilities/views.py b/vulnerabilities/views.py index e96f43a6d..fad42eae8 100644 --- a/vulnerabilities/views.py +++ b/vulnerabilities/views.py @@ -176,7 +176,6 @@ class ApiUserCreateView(generic.CreateView): template_name = "api_user_creation_form.html" def form_valid(self, form): - try: response = super().form_valid(form) except ValidationError: